From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ0yj-0000ly-AP for qemu-devel@nongnu.org; Tue, 12 Jan 2016 10:35:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ0yi-0001Mr-KW for qemu-devel@nongnu.org; Tue, 12 Jan 2016 10:35:25 -0500 References: <1452578622-4492-1-git-send-email-den@openvz.org> <20160112141607.GD4841@noname.redhat.com> <569514E7.8090101@redhat.com> <20160112152051.GG4841@noname.redhat.com> From: Paolo Bonzini Message-ID: <56951D32.5080508@redhat.com> Date: Tue, 12 Jan 2016 16:35:14 +0100 MIME-Version: 1.0 In-Reply-To: <20160112152051.GG4841@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: "Denis V. Lunev" , Laszlo Ersek , qemu-devel@nongnu.org, qemu-block@nongnu.org On 12/01/2016 16:20, Kevin Wolf wrote: > > Flash is already being snapshotted as part of saving RAM state. In > > fact, for this reason the device (at least the one used with OVMF; I > > haven't checked other pflash devices) can simply save it back to disk > > on the migration destination, without the need to use "migrate -b" or > > shared storage. > > Boy, is this ugly... > > What do you do with disk-only snapshots? The recovery only works as long > as you have VM state. Turns out I had misunderstood Denis's patch, but FWIW this _is_ done as part of migration or savevm, so the VM state is available. Paolo