From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ2Qg-0008Cc-9U for qemu-devel@nongnu.org; Tue, 12 Jan 2016 12:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ2Qd-0008RV-3f for qemu-devel@nongnu.org; Tue, 12 Jan 2016 12:08:22 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ2Qc-0008RQ-TF for qemu-devel@nongnu.org; Tue, 12 Jan 2016 12:08:19 -0500 Received: by mail-wm0-x22d.google.com with SMTP id f206so261382654wmf.0 for ; Tue, 12 Jan 2016 09:08:18 -0800 (PST) Sender: Paolo Bonzini References: <87r3hx6040.fsf@linaro.org> <5695081C.1070101@greensocs.com> <87vb6yde8g.fsf@linaro.org> <5695196E.70902@redhat.com> <87twmidbdb.fsf@linaro.org> <569527A0.5080502@redhat.com> <87si22dah3.fsf@linaro.org> <56952D38.40109@redhat.com> <87pox6d8yo.fsf@linaro.org> From: Paolo Bonzini Message-ID: <569532FE.1080407@gnu.org> Date: Tue, 12 Jan 2016 18:08:14 +0100 MIME-Version: 1.0 In-Reply-To: <87pox6d8yo.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] MTTCG sync-up call today? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini Cc: mttcg@greensocs.com, Mark Burton , alvise rigo , QEMU Developers , KONRAD Frederic On 12/01/2016 18:05, Alex Bennée wrote: >> > Does tb_invalidate_phys_page_range not take tb_lock itself? > You are right, I missed that when looking at the original code. I think > Fred was trying to push some of the locks up in his WIP branch causing > these problems. As far as I can see, that's unnecessary. Please keep the patches as small as possible and make things correct first. Otherwise we keep running in circles. Paolo