From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJAdT-0005SX-T4 for qemu-devel@nongnu.org; Tue, 12 Jan 2016 20:54:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJAdS-0007BJ-Rt for qemu-devel@nongnu.org; Tue, 12 Jan 2016 20:54:07 -0500 Message-ID: <5695AD56.2040402@huawei.com> Date: Wed, 13 Jan 2016 09:50:14 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1452612274-30218-1-git-send-email-shannon.zhao@linaro.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ARM: Virt: Don't generate RTC ACPI node when using UEFI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Shannon Zhao Cc: edk2-devel@ml01.01.org, qemu-arm , Laszlo Ersek , QEMU Developers , Ard Biesheuvel On 2016/1/12 23:30, Peter Maydell wrote: > On 12 January 2016 at 15:24, Shannon Zhao wrote: >> > When booting VM through UEFI, UEFI takes ownership of the RTC hardware. >> > To DTB UEFI could call libfdt api to disable the RTC device node, but to >> > ACPI it couldn't do that. Therefore, we don't generate the RTC ACPI >> > device in QEMU when using UEFI. > I don't really understand this. I thought that if we were > using ACPI then we would always be doing it via UEFI? > Currently this is true and maybe for a long time this is also true. > Also I think if UEFI wants to take command of some of the > hardware it ought to be UEFI's job to adjust the tables > accordingly before it passes them on to the guest OS. Yes, the ideal method is adjusting the DSDT table in UEFI. But there is almost no way to parse the DSDT table in UEFI. If we want to support that it will introduce ACPI interpreter. This makes it more complex. There is a discussion [1] about this on the edk2 list. [1]https://www.mail-archive.com/edk2-devel@lists.01.org/msg06301.html Thanks, -- Shannon