From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] blockdev: Error out on negative throttling option values
Date: Wed, 13 Jan 2016 20:21:47 -0700 [thread overview]
Message-ID: <5697144B.2040002@redhat.com> (raw)
In-Reply-To: <w51a8o9iy18.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On 01/13/2016 03:17 AM, Alberto Garcia wrote:
> On Wed 13 Jan 2016 01:52:29 AM CET, Fam Zheng wrote:
>
>> The implicit casting from unsigned int to double changes negative values
>> into large positive numbers and accepts them. We should instead print
>> an error.
>>
>> Check the number range so this case is catched and reported.
s/catched/caught/
>
> I still don't know why qemu_opt_get_number() convert silently negative
> numbers into positive ones, shouldn't it just fail with an "invalid
> parameter" error?
Passing -1 as a synonym for ULLONG_MAX can be convenient. But rejecting
it outright rather than doing wraparound wouldn't hurt libvirt too badly.
>
>> +#define THROTTLE_VALUE_MAX 1000000000000000L
>
> This is larger than LONG_MAX in 32-bit systems, I don't know if you need
> to use LL instead.
You do need LL, not for C99, but for older compilers (hello mingw).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-14 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 0:52 [Qemu-devel] [PATCH v2 0/2] block: Reject negative values for throttling options Fam Zheng
2016-01-13 0:52 ` [Qemu-devel] [PATCH v2 1/2] blockdev: Error out on negative throttling option values Fam Zheng
2016-01-13 10:17 ` Alberto Garcia
2016-01-13 11:02 ` Fam Zheng
2016-01-13 11:13 ` Alberto Garcia
2016-01-14 3:14 ` Fam Zheng
2016-01-14 3:21 ` Eric Blake [this message]
2016-01-13 0:52 ` [Qemu-devel] [PATCH v2 2/2] iotests: Test that negative throttle values are rejected Fam Zheng
2016-01-13 10:02 ` Alberto Garcia
2016-01-14 3:17 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697144B.2040002@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).