From: Laurent Vivier <laurent@vivier.eu>
To: chengang@emindsoft.com.cn, riku.voipio@iki.fi
Cc: peter.maydell@linaro.org, Chen Gang <gang.chen.5i5j@gmail.com>,
qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let lv always match val in do_getsockopt()
Date: Thu, 14 Jan 2016 09:15:54 +0100 [thread overview]
Message-ID: <5697593A.5020304@vivier.eu> (raw)
In-Reply-To: <1452752664-11818-1-git-send-email-chengang@emindsoft.com.cn>
Le 14/01/2016 07:24, chengang@emindsoft.com.cn a écrit :
> From: Chen Gang <chengang@emindsoft.com.cn>
>
> After host_to_target_sock_type(), the length of val may be changed, so
> calculate the related lv, too.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> linux-user/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index fcdca2a..0e95f35 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1841,6 +1841,7 @@ static abi_long do_getsockopt(int sockfd, int level, int optname,
> return ret;
> if (optname == SO_TYPE) {
> val = host_to_target_sock_type(val);
> + lv = (val >> 8) ? 4 : 1;
It seems the kernel always returns sizeof(int) (for all archs), what is
the aim of reducing the size ?
> }
> if (len > lv)
> len = lv;
>
next prev parent reply other threads:[~2016-01-14 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 6:24 [Qemu-devel] [PATCH] linux-user/syscall.c: Let lv always match val in do_getsockopt() chengang
2016-01-14 8:15 ` Laurent Vivier [this message]
2016-01-14 9:01 ` Chen Gang
2016-01-14 9:10 ` Laurent Vivier
2016-01-14 9:37 ` Chen Gang
2016-01-14 9:41 ` Laurent Vivier
2016-01-14 9:44 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697593A.5020304@vivier.eu \
--to=laurent@vivier.eu \
--cc=chengang@emindsoft.com.cn \
--cc=gang.chen.5i5j@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).