qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Chen Gang <chengang@emindsoft.com.cn>, riku.voipio@iki.fi
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let lv always match val in do_getsockopt()
Date: Thu, 14 Jan 2016 10:41:25 +0100	[thread overview]
Message-ID: <56976D45.8060306@vivier.eu> (raw)
In-Reply-To: <56976C49.20705@emindsoft.com.cn>



Le 14/01/2016 10:37, Chen Gang a écrit :
> 
> On 2016年01月14日 17:10, Laurent Vivier wrote:
>>
>> Le 14/01/2016 10:01, Chen Gang a écrit :
>>>
>>> I am not quite sure whether kernel always returns sizeof(int) (I guess,
>>> it should be).
>>
>> it can be 1 only if len is 1, but this is managed below.
>>
> 
> Excuse me, I do not quite understand your meaning.
> 
> For me, if we are sure lv is always 4 for SO_TYPE, we don't need this
> patch.
> 
> If lv may be 1 for SO_TYPE (it means val >> 8 may be zero), after call
> host_to_target_sock_type, val >> 8 may be non-zero, theoretically. In
> this case, we need modify lv to 4.
> 
>>> For me, if you are sure, we can skip this patch.
>>
>> Does it fix something ?
>>
> 
> It is only theoretical, not real world, at present.

So I think we can skip it.

Laurent

  reply	other threads:[~2016-01-14  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14  6:24 [Qemu-devel] [PATCH] linux-user/syscall.c: Let lv always match val in do_getsockopt() chengang
2016-01-14  8:15 ` Laurent Vivier
2016-01-14  9:01   ` Chen Gang
2016-01-14  9:10     ` Laurent Vivier
2016-01-14  9:37       ` Chen Gang
2016-01-14  9:41         ` Laurent Vivier [this message]
2016-01-14  9:44           ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56976D45.8060306@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=chengang@emindsoft.com.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).