From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkfg-0001I1-69 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:22:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJkff-0003Xs-30 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:22:48 -0500 References: <1452653434-14879-1-git-send-email-famz@redhat.com> <1452653434-14879-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <5697CB4F.2040108@redhat.com> Date: Thu, 14 Jan 2016 17:22:39 +0100 MIME-Version: 1.0 In-Reply-To: <1452653434-14879-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fXTbXOHJF7Gfr7PNwwGDh36sjmXQic7rv" Subject: Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fXTbXOHJF7Gfr7PNwwGDh36sjmXQic7rv Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 13.01.2016 03:50, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >=20 > Rewrite mirror_iteration to fix both flaws. >=20 > The output of iotests 109 is updated because we now report the offset > and len slightly differently in mirroring progress. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 333 +++++++++++++++++++++++++++----------= -------- > tests/qemu-iotests/109.out | 80 +++++------ > trace-events | 1 - > 3 files changed, 242 insertions(+), 172 deletions(-) Reviewed-by: Max Reitz --fXTbXOHJF7Gfr7PNwwGDh36sjmXQic7rv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWl8tPAAoJEDuxQgLoOKyt22QIAJKdGebGg0yc9JjaR2+BO5+6 NtiGMq4clnrn8jHNtw09yHmjCN9fu/6KCt3ZOz1U73R9o8VlOImy+Ogg85BtWhuO UxLF/pEdvRRU2jvTOVY3iRgFefX/cP0lGpe1Zd2xw0tAOoCaojjWzkKyjBzC8d1N PPIEftCLL5p1wNPjdlc/oxdCZgYbfkxTvE0pwCofrLoEb3+GXXq2pWqCZJAHTi6R w729wfGNpWW8CVepYYrhDWfuaGNM46RUlZVeD6B6yGLHuV43DpLgMdFq5PLMEC8O O5t2vPc3aGscBt/a2Teneh9abUJSHmSjEbH5LUbRf6BBiCK1y5uc4iny3cGHPzg= =vZyu -----END PGP SIGNATURE----- --fXTbXOHJF7Gfr7PNwwGDh36sjmXQic7rv--