From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkvg-0001aN-Os for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:39:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJkvc-00087q-B7 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:39:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJkvc-00087k-5m for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:39:16 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 62586C0BF2D4 for ; Thu, 14 Jan 2016 16:39:15 +0000 (UTC) References: <1452784405-7097-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5697CF32.9090108@redhat.com> Date: Thu, 14 Jan 2016 09:39:14 -0700 MIME-Version: 1.0 In-Reply-To: <1452784405-7097-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CO6np8OSPVEfDnEhOwbEWR11DH4UC2Pvb" Subject: Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CO6np8OSPVEfDnEhOwbEWR11DH4UC2Pvb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/14/2016 08:13 AM, Markus Armbruster wrote: > The implicit tag member is named "type", not "kind". Screwed up in > commit 39a1815. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake However, there's other errors in the documentation (we haven't kept it up-to-date with recent churn in the generator), so maybe it's better to fix all of them at once. See my Subset E series: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html (I'll probably have to send a v9 of the series, but wanted to see if you had any comments on v8 first) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CO6np8OSPVEfDnEhOwbEWR11DH4UC2Pvb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWl88yAAoJEKeha0olJ0NqFQEH/0kHWDsVSdUmnGlppSG92q11 tT4VPG4vsEnIhcghZp4rYpfTQkUQY24Y2GYCB3S725rU100nbrPUNkEtgmXT1WDm BXQh0K4D5NW5t7FXgRQgNck/mAsYOyrsWStajPBKODp+Ef4NSoocB4OGttK65oG/ GwFZ0VVSrB+LS4tXM1uQQhucos4AlOdDFFKge9K+tFuCE+kpJVWxA9IdSNKXzto/ hOvgTGK9mT5Otx3za5RwRGwWCjqTnM5fXDXvTCOi2clSvPbAyHYRDTPRAgXIpqPd vSsfLNaHHvDF7/u3oprrYAjK8i8ckHVxbQwnLFE9hY5SqiqIhZRck61mBEwi3Bg= =hDCB -----END PGP SIGNATURE----- --CO6np8OSPVEfDnEhOwbEWR11DH4UC2Pvb--