From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJqQ6-0006FX-Ds for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:31:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJqQ2-0000EB-50 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:31:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJqQ1-0000E7-VM for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:31:02 -0500 References: <1452689507-8188-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1452689507-8188-4-git-send-email-caoj.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <569821A4.1030909@redhat.com> Date: Thu, 14 Jan 2016 15:31:00 -0700 MIME-Version: 1.0 In-Reply-To: <1452689507-8188-4-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5pTPxWDX9X9PPG7Kv2NqDugLOP9m7aFEI" Subject: Re: [Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: stefano.stabellini@eu.citrix.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5pTPxWDX9X9PPG7Kv2NqDugLOP9m7aFEI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2016 05:51 AM, Cao jin wrote: > To catch the error msg. Also modify the caller >=20 > Signed-off-by: Cao jin > --- > hw/xen/xen_pt.c | 7 +++++-- > hw/xen/xen_pt.h | 3 ++- > hw/xen/xen_pt_graphics.c | 11 ++++++----- > 3 files changed, 13 insertions(+), 8 deletions(-) >=20 > +++ b/hw/xen/xen_pt_graphics.c > @@ -172,13 +173,14 @@ int xen_pt_setup_vga(XenPCIPassthroughState *s, X= enHostPCIDevice *dev) > struct pci_data *pd =3D NULL; > =20 > if (!is_igd_vga_passthrough(dev)) { > - return -1; > + error_setg(errp, "Need to enable igd-passthrough"); > + return; > } > =20 > bios =3D get_vgabios(s, &bios_size, dev); > if (!bios) { > - XEN_PT_ERR(&s->dev, "VGA: Can't getting VBIOS!\n"); > - return -1; > + error_setg(errp, "VGA: Can't getting VBIOS"); As long as you are touching this, fix the grammar: "VGA: Can't get VBIOS" With that tweak, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5pTPxWDX9X9PPG7Kv2NqDugLOP9m7aFEI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmCGkAAoJEKeha0olJ0Nqa4IIAJN6gvIZnEuieg+oDNvx55bk 2SijkTi9sRNAmw28MyB4F8aQhXHc3xoLnw9lBUMHAoSEIUfWK6wAlKzCQbCSkk/g dkNrpVgK1uTI9x/DyxaAlSuY+/E0PHJ+nUCVlHVlZzD1ENbCbPaF1wX9CPjs/I6o 8vvRnQ7z0jTgD5Kl/jNwok0oT9KrzYcvvfJGqbtbmwqMn5j9VzpTlIjclxXzo0Ic 542B2RwOBwx+fl86DDzuBXhgT6qPGPe17DpaLlTFv97oC1y2KHoJSW4HHW2mg+Q/ +iIGxwDn24p5pdqjv0fRqy+SlQz3kQuZp2LYOpZk/sZ++IR6NSQhD/d9EtfBbdQ= =3FTD -----END PGP SIGNATURE----- --5pTPxWDX9X9PPG7Kv2NqDugLOP9m7aFEI--