From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJqS0-0007L3-FP for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJqRw-0000em-Cp for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:33:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJqRw-0000ei-71 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 17:33:00 -0500 References: <1452689507-8188-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1452689507-8188-5-git-send-email-caoj.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <5698221B.50501@redhat.com> Date: Thu, 14 Jan 2016 15:32:59 -0700 MIME-Version: 1.0 In-Reply-To: <1452689507-8188-5-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OAuQw50g47Mn1hcdfdk0Wu60dJcIhO1Cr" Subject: Re: [Qemu-devel] [PATCH v5 4/5] Add Error **errp for xen_pt_config_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: stefano.stabellini@eu.citrix.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OAuQw50g47Mn1hcdfdk0Wu60dJcIhO1Cr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2016 05:51 AM, Cao jin wrote: > To catch the error msg. Also modify the caller Doesn't hurt to spell out 'message' instead of 'msg' (here and in other patches), but not a show-stopper. >=20 > Signed-off-by: Cao jin > --- > hw/xen/xen_pt.c | 8 ++++--- > hw/xen/xen_pt.h | 2 +- > hw/xen/xen_pt_config_init.c | 51 ++++++++++++++++++++++++-------------= -------- > 3 files changed, 33 insertions(+), 28 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OAuQw50g47Mn1hcdfdk0Wu60dJcIhO1Cr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmCIbAAoJEKeha0olJ0NqPrAH/iHSfV8QGMvRcaaz6yflyFvA ANFRunbweEUf55uV26UHIHMrU8zorVkYgwPC6lPoxuL1q2Lkot06rHSfirEVi1Ss HFwnl0QZaL/RBZJ+nntwD1etcO9xAPTEXONcrud5gbUcIyQyCwi4rLW8W5199Soa rknv+KzU9DZkFbCj5mvuRVn4kM7BygEl3yj6H3uNKUKIOkNQd04t4DCyZ/XVsINW 56STLkHl9AXwROre3EFaekw9e7MYFTPQBPuVLB2Q9DiUBJ939WLHO9YTUl7ahAZK j3dn4HzDB1ZZcP25X2giKqccA5Q6gg4mmZzpzOEejIS3cwedd+BvqAjwQlE1mLU= =m6XC -----END PGP SIGNATURE----- --OAuQw50g47Mn1hcdfdk0Wu60dJcIhO1Cr--