From: Shannon Zhao <shannon.zhao@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Laszlo Ersek <lersek@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Shannon Zhao <zhaoshenglong@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI
Date: Fri, 15 Jan 2016 22:37:25 +0800 [thread overview]
Message-ID: <56990425.3020004@linaro.org> (raw)
In-Reply-To: <CAFEAcA_f=j0KupJG6z1E+O7oqbhgKbSCdUob9GOdsEQRCBuz_w@mail.gmail.com>
On 2016/1/15 22:34, Peter Maydell wrote:
> On 13 January 2016 at 16:26, Laszlo Ersek<lersek@redhat.com> wrote:
>> >On 01/13/16 17:16, Andrew Jones wrote:
>>> >>On Wed, Jan 13, 2016 at 10:54:17PM +0800, Shannon Zhao wrote:
>>>> >>>When booting the VM with UEFI, UEFI takes ownership of the RTC hardware.
>>>> >>>While UEFI can use libfdt to disable the RTC device node in the DTB that
>>>> >>>it passes to the OS, it cannot modify AML. Therefore, we won't generate
>>>> >>>the RTC ACPI device at all when using UEFI.
>>> >>
>>> >>I think a condensed comment similar to this commit message would be nice
>>> >>in build_dsdt, or somewhere. We have a policy for mach-virt of generating
>>> >>ACPI for everything we generate DT. It'd be good if we documented all the
>>> >>divergences in order to avoid confusion. [...]
>> >
>> >Good idea!
> I'm happy with the code in this patch, so you can add my
> Reviewed-by: Peter Maydell<peter.maydell@linaro.org>
>
Sorry, missed this. I've sent the v3.
> Shannon, I'm assuming you're planning a v3 with the comment that
> Andrew and Laszlo suggest.
--
Shannon
prev parent reply other threads:[~2016-01-15 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 14:54 [Qemu-devel] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI Shannon Zhao
2016-01-13 15:04 ` Ard Biesheuvel
2016-01-13 15:06 ` Laszlo Ersek
2016-01-13 16:16 ` Andrew Jones
2016-01-13 16:26 ` Laszlo Ersek
2016-01-15 14:34 ` Peter Maydell
2016-01-15 14:37 ` Shannon Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56990425.3020004@linaro.org \
--to=shannon.zhao@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=edk2-devel@ml01.01.org \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).