From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK6lv-0005G5-33 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:58:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK6lq-0001uG-0W for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:58:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK6lp-0001uC-RR for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:58:37 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9930B8E221 for ; Fri, 15 Jan 2016 15:58:36 +0000 (UTC) References: <1452516281-27519-1-git-send-email-berrange@redhat.com> <56986FEF.1040307@redhat.com> <20160115091502.GA2863@redhat.com> From: Paolo Bonzini Message-ID: <56991727.5040901@redhat.com> Date: Fri, 15 Jan 2016 16:58:31 +0100 MIME-Version: 1.0 In-Reply-To: <20160115091502.GA2863@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] qemu-char: add logfile facility to all chardev backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Eric Blake Cc: qemu-devel@nongnu.org, Markus Armbruster On 15/01/2016 10:15, Daniel P. Berrange wrote: > On Thu, Jan 14, 2016 at 09:05:03PM -0700, Eric Blake wrote: >> On 01/11/2016 05:44 AM, Daniel P. Berrange wrote: >>> Typically a UNIX guest OS will log boot messages to a serial >>> port in addition to any graphical console. An admin user >>> may also wish to use the serial port for an interactive >>> console. A virtualization management system may wish to >>> collect system boot messages by logging the serial port, >>> but also wish to allow admins interactive access. >>> >> >>> This patch introduces a 'ChardevCommon' struct which >>> is setup as a base for all the ChardevBackend types. >>> Ideally this would be registered directly as a base >>> against ChardevBackend, rather than each type, but >>> the QAPI generator doesn't allow that since the >>> ChardevBackend is a non-discriminated union. The >>> ChardevCommon struct provides the optional 'logfile' >>> parameter, as well as 'logappend' which controls >>> whether QEMU truncates or appends (default truncate). >>> >>> Signed-off-by: Daniel P. Berrange This patch fails make check, due to a segmentation fault that can be reproduced with "x86_64-softmmu/qemu-system-x86_64 -serial null". I'm squashing in the fix: diff --git a/qemu-char.c b/qemu-char.c index 02b0318..11caa56 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3827,7 +3827,12 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts, error_propagate(errp, local_err); goto qapi_out; } + } else { + ChardevCommon *cc = g_new0(ChardevCommon, 1); + qemu_chr_parse_common(opts, cc); + backend->u.data = cc; } + ret = qmp_chardev_add(bid ? bid : id, backend, errp); if (!ret) { goto qapi_out; Paolo