From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aK6q0-0006ZE-3E
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:02:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aK6ps-0002zs-DH
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:02:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50137)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aK6ps-0002zZ-82
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:02:48 -0500
References: <87oacqd7v9.fsf@linaro.org>
	<CAJhHMCA-cwrBYS+HRft6obkGr5Wrvk=9f0Y4gCOOL2R0ODdF=A@mail.gmail.com>
	<87bn8nc5kb.fsf@linaro.org>
	<CAJhHMCA9jzt4omnRdCwbLH0pdvN-CK_myeQMxqBxRkT+yXJSSA@mail.gmail.com>
	<56990295.1050307@greensocs.com> <87a8o6dhog.fsf@linaro.org>
	<56990712.2050107@greensocs.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56991822.6020309@redhat.com>
Date: Fri, 15 Jan 2016 17:02:42 +0100
MIME-Version: 1.0
In-Reply-To: <56990712.2050107@greensocs.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Status of my hacks on the MTTCG WIP branch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: KONRAD Frederic <fred.konrad@greensocs.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>
Cc: MTTCG Devel <mttcg@greensocs.com>, Pranith Kumar <bobby.prani@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, alvise rigo <a.rigo@virtualopensystems.com>



On 15/01/2016 15:49, KONRAD Frederic wrote:
> 
>        /* Move the TB to the head of the list */
> -    *ptb1 = tb->phys_hash_next;
> -    tb->phys_hash_next = tcg_ctx.tb_ctx.tb_phys_hash[h];
> -    tcg_ctx.tb_ctx.tb_phys_hash[h] = tb;
> +//    *ptb1 = tb->phys_hash_next;
> +//    tb->phys_hash_next = tcg_ctx.tb_ctx.tb_phys_hash[h];
> +//    tcg_ctx.tb_ctx.tb_phys_hash[h] = tb;

This is the right fix.  It's a *huge* performance hit to take the
tb_lock around tb_find_fast.

Paolo