From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7Zq-0004hN-SG for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:50:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7Zn-0007oU-Jm for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:50:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7Zn-0007nq-Ea for qemu-devel@nongnu.org; Fri, 15 Jan 2016 11:50:15 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4E3C9344EB3 for ; Fri, 15 Jan 2016 16:50:14 +0000 (UTC) References: <1452518225-11751-1-git-send-email-berrange@redhat.com> <1452518225-11751-3-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56992345.5030506@redhat.com> Date: Fri, 15 Jan 2016 09:50:13 -0700 MIME-Version: 1.0 In-Reply-To: <1452518225-11751-3-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hU2WU3r3jxNdTcpL62fjahsoFnRJ8XhwG" Subject: Re: [Qemu-devel] [PATCH v3 2/5] sockets: remove use of QemuOpts from socket_listen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hU2WU3r3jxNdTcpL62fjahsoFnRJ8XhwG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/11/2016 06:17 AM, Daniel P. Berrange wrote: > The socket_listen method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_listen_opts/unix_listen_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpts conversion step can be eliminated >=20 > Signed-off-by: Daniel P. Berrange > --- > util/qemu-sockets.c | 154 +++++++++++++++++++++++++++++++++-----------= -------- > 1 file changed, 97 insertions(+), 57 deletions(-) >=20 > + * > + * NB, this matrix is only about getting the neccessary results s/neccessary/necessary/ With the typo fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hU2WU3r3jxNdTcpL62fjahsoFnRJ8XhwG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmSNFAAoJEKeha0olJ0NqcYQIAIGKu9v2SbcWalHCq/XtZ0iN dCNbt9APNrG///cUnD0rJqkrkKjEWyga1Xu3oIhmwI7RMLs2Qww9HyYtyvGcCxfb WUHKsvTY/kh1/7F78SlvYJpoywbNyHptHVn53KDmBJ9m8I8fUXpCnZoGpSz6nhCn 9XWzDwCEII3vd6l3g1L5QQFTNDcnkVdh/CDAFgBEtHGu8iiUTvdd4cnPWnznQ5Ej xSz72OZX3rMPv55NYiqcoKb1E7uaTdxoCWJifZJiKRdaJ9GNe+28uLsC9hHmPD1X LEDGdpp/d8iB/bAgBANHDo/OMhojEwLpwVXGIBRhbHsoLgCV5rkEBbRVv5btd+M= =X80F -----END PGP SIGNATURE----- --hU2WU3r3jxNdTcpL62fjahsoFnRJ8XhwG--