From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7rC-000565-GT for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:08:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7rB-0004NQ-MI for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:08:14 -0500 References: <1452613674-12248-1-git-send-email-mreitz@redhat.com> <1452613674-12248-3-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56992776.2090907@redhat.com> Date: Fri, 15 Jan 2016 10:08:06 -0700 MIME-Version: 1.0 In-Reply-To: <1452613674-12248-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jeILsj4ww8heFc9IVOCA3LXPQeCPfKssE" Subject: Re: [Qemu-devel] [PATCH 2/4] blockdev: Fix 'change' for slot devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Peter Maydell , Markus Armbruster , qemu-devel@nongnu.org, qemu-stable , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jeILsj4ww8heFc9IVOCA3LXPQeCPfKssE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/12/2016 08:47 AM, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices= > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required it to return true. >=20 > Fix this by making blockdev-{insert,remove}-medium work on tray-less > devices. Also, blockdev-{open,close}-tray are now explicitly no-ops whe= n > invoked on such devices, and blk_dev_change_media_cb() is instead > called by blockdev-{insert,remove}-medium (for tray-less devices only).= >=20 > Reported-by: Peter Maydell > Cc: qemu-stable > Signed-off-by: Max Reitz > --- > blockdev.c | 27 +++++++++++++++++++++++++-- > qapi/block-core.json | 3 +-- > 2 files changed, 26 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jeILsj4ww8heFc9IVOCA3LXPQeCPfKssE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmSd2AAoJEKeha0olJ0Nqr/wIAI356tp/RvA0CPPe4bj9DUKV 1yjmUgUTK3ewfxIIS8wbNIgYTo/oGeShIRGCESJ+18h32aaprtBbmAL68rFFdnNS LD0WulKHda1x6F5aC8kwa+tdkb4ojmfLoBNzMl/S9lU6mRdvv+4z+loCmRZbEM4V meyNGcHEPZup6W+ygaOBJ7Eout2QPoxWtv3XVA7Tk8+cbT7PvmJGizY0CXyxzz/k yyXtlGuIqoABgs57EXALJWbHoy1s3glYTfI4kKJ8RL0MuvZFMPDeb+6aGqHB5YhR 785gI1wccZNg/KcgIVGAdIEKMunaWD97GDh2T+Zvut83sKWDfNZFU6ue/m7sfK4= =mfxZ -----END PGP SIGNATURE----- --jeILsj4ww8heFc9IVOCA3LXPQeCPfKssE--