From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7u0-0007im-DV for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:11:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7tz-00050I-Fr for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:11:08 -0500 References: <1452613674-12248-1-git-send-email-mreitz@redhat.com> <1452613674-12248-4-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56992824.6000806@redhat.com> Date: Fri, 15 Jan 2016 10:11:00 -0700 MIME-Version: 1.0 In-Reply-To: <1452613674-12248-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m4sFtLCSvK5p4tR3M3552gx37oN4bo8r3" Subject: Re: [Qemu-devel] [PATCH 3/4] Revert "hw/block/fdc: Implement tray status" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Peter Maydell , John Snow , Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --m4sFtLCSvK5p4tR3M3552gx37oN4bo8r3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/12/2016 08:47 AM, Max Reitz wrote: > This reverts the changes commit > 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c. >=20 Might read better as s/changes commit/changes that commit/ > That commit changed tests/fdc-test.c, too, because after it, one less > TRAY_MOVED event would be emitted when executing 'change' on an empty > drive. However, now, no TRAY_MOVED events will be emitted at all, and > the tray_open status returned by query-block will always be false, > necessitating (different) changes to tests/fdc-test.c and iotest 118, > which is why this patch is not a pure revert of said commit. >=20 > Signed-off-by: Max Reitz > --- > hw/block/fdc.c | 20 ++------- > tests/fdc-test.c | 2 - > tests/qemu-iotests/118 | 117 +++++++++++++++--------------------------= -------- > 3 files changed, 40 insertions(+), 99 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --m4sFtLCSvK5p4tR3M3552gx37oN4bo8r3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmSgkAAoJEKeha0olJ0NqGfMH/0MdkB3ZmeQ2lJ/tF2AujZMv UfXDvncld1m2yo0HrzQEQRemEBVY/HODGaLcLohd4Vnwg4XVwLF0EiF9E/rkLDxZ 7By4FPVtNe5h+6UAyi9epQxkwjPxCxyPGbGHAU86m2ylaoTaryG6Ez/VJrtUFY5N FWj04r5plyf2PJcrSZYONNOjnUclsmDZaK+KrvSupy2eZr/adZt4uxOXZDrQ7Ohn yI4kX3VSFcQj72Ac4qqBSLsqqcRCvRG7ruaTjbKn7vK+Rft9qtLQ7uM9M0WZw5Nj BLXc8csPOzYb1PYC+HHordfkKRUTl9IoMALxR1DTv3v4RrwJWWx5RxQEj1fBBKs= =aCCD -----END PGP SIGNATURE----- --m4sFtLCSvK5p4tR3M3552gx37oN4bo8r3--