From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK8yr-0004kM-Aj for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:20:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK8ym-0005re-71 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:20:13 -0500 Received: from mail-qg0-x242.google.com ([2607:f8b0:400d:c04::242]:33492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK8ym-0005r8-2a for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:20:08 -0500 Received: by mail-qg0-x242.google.com with SMTP id o11so47345814qge.0 for ; Fri, 15 Jan 2016 10:20:08 -0800 (PST) Sender: Richard Henderson References: <145287209895.25408.12995870835200275306.stgit@localhost> <145287210479.25408.17499099590726683703.stgit@localhost> From: Richard Henderson Message-ID: <56993854.1030802@twiddle.net> Date: Fri, 15 Jan 2016 10:20:04 -0800 MIME-Version: 1.0 In-Reply-To: <145287210479.25408.17499099590726683703.stgit@localhost> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: "Edgar E . Iglesias" , peter.maydell@linaro.org On 01/15/2016 07:35 AM, Lluís Vilanova wrote: > +TCGv_i64 tcg_promise_i64(TCGv_promise_i64 *promise) > +{ > + int pi = tcg_ctx.gen_next_parm_idx; > + *promise = (TCGv_promise_i64)&tcg_ctx.gen_opparam_buf[pi]; > + return tcg_const_i64(0xdeadcafe); > +} This doesn't work for a 32-bit host. The constant may be split across two different parameter indices, and you don't know exactly where the second will be. Because of that, I think this is over-engineered, and really prefer the simpler interface that Edgar posted last week. r~