From: Eric Blake <eblake@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
Date: Fri, 15 Jan 2016 16:33:59 -0700 [thread overview]
Message-ID: <569981E7.3010607@redhat.com> (raw)
In-Reply-To: <1452607738-1521-1-git-send-email-cfergeau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On 01/12/2016 07:08 AM, Christophe Fergeau wrote:
> Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
> QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
> spice_server_init() will get called without a previous call to
> spice_server_set_sasl_appname(), which will cause cyrus-sasl to
> try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
> default appname) rather than the expected /etc/sasl2/qemu.conf.
>
> This commit unconditionnally calls spice_server_set_sasl_appname()
s/unconditionnally/unconditionally/
> before calling spice_server_init() in order to use the correct appname
> even if SPICE without SASL was requested on qemu command line.
>
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-15 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 14:08 [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE Christophe Fergeau
2016-01-12 14:27 ` Gerd Hoffmann
2016-01-15 23:33 ` Eric Blake [this message]
2016-01-18 10:11 ` Gerd Hoffmann
2016-01-18 10:41 ` Christophe Fergeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569981E7.3010607@redhat.com \
--to=eblake@redhat.com \
--cc=cfergeau@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).