From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKDsa-0000Bk-EH for qemu-devel@nongnu.org; Fri, 15 Jan 2016 18:34:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKDsX-0002fG-2M for qemu-devel@nongnu.org; Fri, 15 Jan 2016 18:34:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKDsW-0002fC-T0 for qemu-devel@nongnu.org; Fri, 15 Jan 2016 18:34:00 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 8C0BD8E913 for ; Fri, 15 Jan 2016 23:34:00 +0000 (UTC) References: <1452607738-1521-1-git-send-email-cfergeau@redhat.com> From: Eric Blake Message-ID: <569981E7.3010607@redhat.com> Date: Fri, 15 Jan 2016 16:33:59 -0700 MIME-Version: 1.0 In-Reply-To: <1452607738-1521-1-git-send-email-cfergeau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="etSnaEgrKtlk7TAu9IT4vdbdtAaIR2LgW" Subject: Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau , qemu-devel@nongnu.org Cc: Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --etSnaEgrKtlk7TAu9IT4vdbdtAaIR2LgW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/12/2016 07:08 AM, Christophe Fergeau wrote: > Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting > QEMU with SPICE but no SASL, and at the same time VNC with SASL, then > spice_server_init() will get called without a previous call to > spice_server_set_sasl_appname(), which will cause cyrus-sasl to > try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its > default appname) rather than the expected /etc/sasl2/qemu.conf. >=20 > This commit unconditionnally calls spice_server_set_sasl_appname() s/unconditionnally/unconditionally/ > before calling spice_server_init() in order to use the correct appname > even if SPICE without SASL was requested on qemu command line. >=20 > Signed-off-by: Christophe Fergeau > --- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --etSnaEgrKtlk7TAu9IT4vdbdtAaIR2LgW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmYHnAAoJEKeha0olJ0Nqd5kH/0F+rmHm+J50JXphByjP70Xs JnCs3rMnZ4/+VRIP8GwjGTlOxCCRe4Jocj7LI2lpDgQwTljN2BixKxAfDoc9538v uWnKxy+v4/0L6j1t69Rd6BMgx7kEM1xNYa5p16tElmD/b7wt+kEos8zqKMGErRNn zFYJghSM2WdGI8KinuNdGTT4TklX8GcFFVplLGMJle8YGzSTCLuRPAtSycOVUHKZ scFk34ueJIYa5zSAOrs8yM9omyAdhivK/W6WSwrM4h76LHYXkVYRdf6LdMNCtnrz LsQXr/hQFH8fsQArNqH5+H8EakrhU/7jj2ys1wN3ReYjuD+sEYLaH4qN6b4avwo= =05g7 -----END PGP SIGNATURE----- --etSnaEgrKtlk7TAu9IT4vdbdtAaIR2LgW--