From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKxBw-0000xP-29 for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:57:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKxBr-0008N4-LD for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:57:04 -0500 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:34677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKxBr-0008My-EH for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:56:59 -0500 Received: by mail-pa0-x242.google.com with SMTP id yy13so31860860pab.1 for ; Sun, 17 Jan 2016 15:56:59 -0800 (PST) References: <1452859244-9500-1-git-send-email-david@gibson.dropbear.id.au> <8760yuyhcm.fsf@blackfin.pond.sub.org> From: Alexey Kardashevskiy Message-ID: <569C2A46.50202@ozlabs.ru> Date: Mon, 18 Jan 2016 10:56:54 +1100 MIME-Version: 1.0 In-Reply-To: <8760yuyhcm.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] Cleanups to error reporting on ppc and spapr (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , David Gibson Cc: qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org On 01/16/2016 02:47 AM, Markus Armbruster wrote: > David Gibson writes: > >> Here's a new spin of my patches to clean up a bunch of error reporting >> in the pseries machine type and target-ppc code, to better use the >> error API. >> >> Once reviewed, I hope to merge this into ppc-for-2.6 shortly. > > There's an error_setg(&error_abort, ...) left in spapr_drc.c. Should > that be converted to a straight abort()? > I was under impression that all abort()/exit() instances are aimed to be converted to error_setg(&error_abort) eventually (as all fprintf(error) to perror() and tracepoints, etc), is there any howto what to use when? :) -- Alexey