From: Laurent Vivier <laurent@vivier.eu>
To: Paolo Bonzini <pbonzini@redhat.com>,
peter.maydell@linaro.org, riku.voipio@iki.fi
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls
Date: Mon, 18 Jan 2016 11:36:20 +0100 [thread overview]
Message-ID: <569CC024.9030604@vivier.eu> (raw)
In-Reply-To: <569CBED1.8030101@redhat.com>
Le 18/01/2016 11:30, Paolo Bonzini a écrit :
>
>
> On 02/10/2015 14:48, Laurent Vivier wrote:
>> + target_fd_trans = g_realloc(target_fd_trans,
>> + target_fd_max * sizeof(TargetFdTrans));
>
> This should be TargetFdTrans * (reported by Coverity). Even better you
> could use g_renew.
>
> It's harmless because sizeof(TargetFdTrans) > sizeof(TargetFdTrans *),
> but it should be fixed nevertheless.
OK, thank you Paolo.
I will fix that.
Laurent
prev parent reply other threads:[~2016-01-18 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 12:48 [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls Laurent Vivier
2015-10-06 8:16 ` Riku Voipio
2015-11-21 21:57 ` Laurent Vivier
2015-12-18 15:11 ` Laurent Vivier
2016-01-18 10:30 ` Paolo Bonzini
2016-01-18 10:36 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CC024.9030604@vivier.eu \
--to=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).