From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL7Kw-0000vF-Tw for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aL7Kt-0007cS-Lp for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:47:02 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL7Kt-0007bv-Em for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:46:59 -0500 Received: by mail-wm0-x243.google.com with SMTP id u188so15731049wmu.0 for ; Mon, 18 Jan 2016 02:46:59 -0800 (PST) References: From: Marcel Apfelbaum Message-ID: <569CC2A0.3040800@gmail.com> Date: Mon, 18 Jan 2016 12:46:56 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v16 14/14] vfio: add 'aer' property to expose aercap Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com, mst@redhat.com On 01/12/2016 04:43 AM, Cao jin wrote: > From: Chen Fan > > add 'aer' property to let user able to decide whether expose > the aer capability. by default we should disable aer feature, > because it needs configuration restrictions. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index efa5e01..9afb5e0 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3119,6 +3119,8 @@ static Property vfio_pci_dev_properties[] = { > sub_vendor_id, PCI_ANY_ID), > DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice, > sub_device_id, PCI_ANY_ID), > + DEFINE_PROP_BIT("aer", VFIOPCIDevice, features, > + VFIO_FEATURE_ENABLE_AER_BIT, false), > /* > * TODO - support passed fds... is this necessary? > * DEFINE_PROP_STRING("vfiofd", VFIOPCIDevice, vfiofd_name), > Reviewed-by: Marcel Apfelbaum Thanks, Marcel