From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1aLDrl-0000LM-D9
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 12:45:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1aLDrg-0006Gz-Dz
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 12:45:21 -0500
References: <1453091992-961-1-git-send-email-david@gibson.dropbear.id.au>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <569D24AA.6010507@suse.de>
Date: Mon, 18 Jan 2016 18:45:14 +0100
MIME-Version: 1.0
In-Reply-To: <1453091992-961-1-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of
 FindSysbusDeviceFunc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: scottwood@freescale.com, peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org

Am 18.01.2016 um 05:39 schrieb David Gibson:
> Functions of type FindSysbusDeviceFunc currently return an integer.  I
> recently made an error in a patch because I assumed that this return va=
lue
> would control whether iteration of the function across devices continue=
s
> or not.  In fact, the function's return value is always ignored.
>=20
> This changes the function type to return void, so that others don't mak=
e
> the same mistake.

Have you considered implementing the behavior you expected? :)
Not necessary for your use case or too complicated?

>=20
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>=20
> Please apply.

Patch looks okay, too short notice for today's pull though.
Usually we avoid "I" in a commit message.

Regards,
Andreas

>=20
>  hw/arm/sysbus-fdt.c    | 4 ++--
>  hw/core/machine.c      | 2 +-
>  hw/core/platform-bus.c | 8 ++------
>  hw/ppc/e500.c          | 4 +---
>  hw/ppc/spapr.c         | 4 +---
>  include/hw/sysbus.h    | 2 +-
>  6 files changed, 8 insertions(+), 16 deletions(-)

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)