From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLFnT-0005v6-UB for qemu-devel@nongnu.org; Mon, 18 Jan 2016 14:49:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLFnT-00026L-19 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 14:49:03 -0500 References: <1452624982-19332-1-git-send-email-berrange@redhat.com> <1452624982-19332-6-git-send-email-berrange@redhat.com> <5696E06F.7060906@redhat.com> <20160114121604.GM910@redhat.com> From: Eric Blake Message-ID: <569D41A8.3000708@redhat.com> Date: Mon, 18 Jan 2016 12:48:56 -0700 MIME-Version: 1.0 In-Reply-To: <20160114121604.GM910@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DFFffufMScU10CBs6EWwodAjtR0wDUkRG" Subject: Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DFFffufMScU10CBs6EWwodAjtR0wDUkRG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use >>> +# >> >> Well, the only reason to use it would be to read data off an old >> insecurely-encrypted qcow2 file; so maybe it should read "Do not use o= n >> new files" >=20 > Yep >=20 >>> +# Since: 2.6 >>> +## >>> +{ 'enum': 'QCryptoBlockFormat', >>> +# 'prefix': 'QCRYPTO_BLOCK_FORMAT', >>> + 'data': ['qcowaes']} >> >> Would 'qcow-aes' be any easier to read? >=20 > Or just shorten to 'qcow' perhaps ? Or maybe 'old-qcow' to emphasize that it is old? At this point, we're painting the bikeshed, so I'll live with whatever you like. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DFFffufMScU10CBs6EWwodAjtR0wDUkRG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWnUGoAAoJEKeha0olJ0NqC6wIAKPg1tGKQgNBhIXsGO8Vk8Zz KdKYj9bS8J8IaxOOKXw/DVSJevv1PEHP88n96itNUtPu8ZOIOD+iEHf6/am4hSvL ybiDmK+OIHRR5Rt+6ZOKroYX2/QI/VrkGJt1MR/gAK45T6bVdWqudFUMmWgc1TYZ VQWh55wEcaZbX0R6L23Ti5Dj4NdG3RkpNOad8JHt9vY29oMtay70XpwbDy68vfLS zZLsYhmkjLcMLBMWlDrDXws8E52d8ewULQwRtk/+XsRfScbwGu2YJr8jF7qyYivC emeXk7BxMSTEtHrmnMEb92TZDGYmTlpBGy3xaRZXUqlkS6KnK/mWYDVZMJ5GcBE= =IPKI -----END PGP SIGNATURE----- --DFFffufMScU10CBs6EWwodAjtR0wDUkRG--