From: Eric Blake <eblake@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] [PATCH v6 1/6] Change xen_host_pci_sysfs_path() to return void
Date: Mon, 18 Jan 2016 13:30:22 -0700 [thread overview]
Message-ID: <569D4B5E.8060109@redhat.com> (raw)
In-Reply-To: <1453032795-12690-2-git-send-email-caoj.fnst@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On 01/17/2016 05:13 AM, Cao jin wrote:
> And assert the snprintf() error, because user can do nothing in case of
> snprintf() fail.
s/fail/failure/
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/xen/xen-host-pci-device.c | 35 +++++++++++------------------------
> 1 file changed, 11 insertions(+), 24 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-18 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 12:13 [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert to realize() Cao jin
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 1/6] Change xen_host_pci_sysfs_path() to return void Cao jin
2016-01-18 20:30 ` Eric Blake [this message]
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 2/6] Xen: use qemu_strtoul instead of strtol Cao jin
2016-01-20 0:09 ` Eric Blake
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 3/6] Add Error **errp for xen_host_pci_device_get() Cao jin
2016-01-21 16:23 ` Eric Blake
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 4/6] Add Error **errp for xen_pt_setup_vga() Cao jin
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 5/6] Add Error **errp for xen_pt_config_init() Cao jin
2016-01-17 12:13 ` [Qemu-devel] [PATCH v6 6/6] Xen PCI passthru: convert to realize() Cao jin
2016-01-19 1:38 ` [Qemu-devel] [PATCH v6 0/6] Xen PCI passthru: Convert " Cao jin
2016-01-19 7:22 ` Markus Armbruster
2016-01-21 13:26 ` Cao jin
2016-01-21 15:41 ` Stefano Stabellini
2016-01-21 16:24 ` Eric Blake
2016-01-21 16:39 ` Stefano Stabellini
2016-01-22 6:00 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D4B5E.8060109@redhat.com \
--to=eblake@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).