From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Alistair Francis" <alistair.francis@xilinx.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Prasad Pandit" <ppandit@redhat.com>,
"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>, 刘令 <liuling-it@360.cn>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow
Date: Tue, 19 Jan 2016 10:48:06 +0800 [thread overview]
Message-ID: <569DA3E6.5020407@redhat.com> (raw)
In-Reply-To: <CAFEAcA9DZ6OhN=cXVrbZftazX9eJb1eKRLG2D+Vp6mYnoXP60g@mail.gmail.com>
On 01/18/2016 06:06 PM, Peter Maydell wrote:
> On 18 January 2016 at 09:57, Jason Wang <jasowang@redhat.com> wrote:
>> Thanks for the pointer.
>>
>> In section 16.1.5, it said
>>
>> "Jumbo frames are not supported."
>>
>> So it was in fact not an unimplemented feature?
> I have a vague feeling from the last time I looked at something like
> this that what often happens is the hardware happily goes on dumping
> data out on the wire but this is a violation of the ethernet protocol,
> ie a guest error. But I'm no ethernet expert...
>
> thanks
> -- PMM
>
I think it's a guest error (unless we find a guest/driver that depends
on this). Anyway, fixing the buffer overflow should be fine.
prev parent reply other threads:[~2016-01-19 2:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 9:43 [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow Michael S. Tsirkin
2016-01-14 10:03 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-01-14 10:11 ` Michael S. Tsirkin
2016-01-15 6:19 ` Peter Crosthwaite
2016-01-15 8:06 ` P J P
2016-01-16 0:20 ` Alistair Francis
2016-01-16 5:23 ` P J P
2016-01-18 3:14 ` Jason Wang
2016-01-14 10:23 ` [Qemu-devel] " P J P
2016-01-15 3:16 ` Jason Wang
2016-01-15 5:39 ` P J P
2016-01-18 6:50 ` Jason Wang
2016-01-18 7:04 ` Peter Crosthwaite
2016-01-18 8:12 ` Jason Wang
2016-01-18 9:08 ` Peter Crosthwaite
2016-01-18 9:57 ` Jason Wang
2016-01-18 10:06 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-01-18 16:54 ` Alistair Francis
2016-01-19 2:48 ` Jason Wang
2016-01-19 2:48 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569DA3E6.5020407@redhat.com \
--to=jasowang@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=crosthwaitepeter@gmail.com \
--cc=liuling-it@360.cn \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).