From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLW76-0006By-L2 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 08:14:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLW71-0007AS-D6 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 08:14:24 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLW71-00079y-5N for qemu-devel@nongnu.org; Tue, 19 Jan 2016 08:14:19 -0500 Received: by mail-wm0-x243.google.com with SMTP id l65so23180570wmf.3 for ; Tue, 19 Jan 2016 05:14:16 -0800 (PST) Sender: Paolo Bonzini References: <1453202071-10289-1-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <569E36A5.7030501@redhat.com> Date: Tue, 19 Jan 2016 14:14:13 +0100 MIME-Version: 1.0 In-Reply-To: <1453202071-10289-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/4] Convert chardevs to QIOChannel & add TLS support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org On 19/01/2016 12:14, Daniel P. Berrange wrote: > This is an update of patches previously shown in an RFC posting > > RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04222.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03823.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01601.html > > This short series converts the chardev backends to use the new > QIOChannel framework. After doing so it then adds support for > TLS encryption of TCP chardevs. The commit message in the last > patch explains the TLS encryption in detail. > > The GIOChannel -> QIOChannel conversion has been validated by > running the qtest framework, which indeed found a few bugs > initially which I have since fixed. > > The TLS support has been tested for interoperability using > the gnutls-serv and gnutls-client programs which provide > stub TLS endpoints/clients respectively. > > Changed in v4: > > - Rebase to resolve conflicts with recent merged patches Thanks, this looks good! Paolo > Changed in v3: > > - Fix buffer update after partial send of telnet data > > Daniel P. Berrange (4): > char: remove fixed length filename allocation > char: convert from GIOChannel to QIOChannel > char: don't assume telnet initialization will not block > char: introduce support for TLS encrypted TCP chardev backend > > qapi-schema.json | 2 + > qemu-char.c | 913 ++++++++++++++++++++++++++++--------------------------- > qemu-options.hx | 9 +- > tests/Makefile | 2 +- > 4 files changed, 479 insertions(+), 447 deletions(-) >