From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLqcx-0001ke-4P for qemu-devel@nongnu.org; Wed, 20 Jan 2016 06:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLqct-0006lb-SF for qemu-devel@nongnu.org; Wed, 20 Jan 2016 06:08:39 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:33296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLqct-0006lX-IA for qemu-devel@nongnu.org; Wed, 20 Jan 2016 06:08:35 -0500 Received: by mail-wm0-x241.google.com with SMTP id u188so3344936wmu.0 for ; Wed, 20 Jan 2016 03:08:35 -0800 (PST) Sender: Paolo Bonzini References: <1452525484-32309-1-git-send-email-frankja@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <569F6AB0.10801@redhat.com> Date: Wed, 20 Jan 2016 12:08:32 +0100 MIME-Version: 1.0 In-Reply-To: <1452525484-32309-1-git-send-email-frankja@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janosch Frank Cc: qemu-devel@nongnu.org On 11/01/2016 16:17, Janosch Frank wrote: > Kvm_stat is a very helpful script for checking the state of VMs, but > when I tried to introduce new features it broke every few lines. > > This patch series aims to make the script more readable and durable, > so future additions to it will break it less likely. It also fixes > input/output problems for all of its interface modes. > > Testing was done rarely on X86_64 RHEL 6.7 and mostly on s390. Tests > on other architectures would be beneficial. > > Changes in v2: > Dropped scripts/kvm/kvm_stat: Move to argparse and add description > Added scripts/kvm/kvm_stat: Add optparse description > > Exchanged PATH_DEBUGFS with PATH_DEBUGFS_KVM > Exchanged PATH_TRACING with PATH_DEBUGFS_TRACING > Exchanged os.os with os > > Split up get_online_cpu. > Now using standard parameters to pass data to an Event object. > Grouped arch specific data in Arch subclasses. > Implemented curse wrapping through magic enter/exit in the Tui class. > > Janosch Frank (34): > scripts/kvm/kvm_stat: Cleanup of multiple imports > scripts/kvm/kvm_stat: Replaced os.listdir with os.walk > scripts/kvm/kvm_stat: Make constants uppercase > scripts/kvm/kvm_stat: Removed unneeded PERF constants > scripts/kvm/kvm_stat: Mark globals in functions > scripts/kvm/kvm_stat: Invert dictionaries > scripts/kvm/kvm_stat: Cleanup of path variables > scripts/kvm/kvm_stat: Improve debugfs access checking > scripts/kvm/kvm_stat: Introduce main function > scripts/kvm/kvm_stat: Fix spaces around keyword assignments > scripts/kvm/kvm_stat: Rename variables that redefine globals > scripts/kvm/kvm_stat: Moved DebugfsProvider > scripts/kvm/kvm_stat: Fixup syscall error reporting > scripts/kvm/kvm_stat: Set sensible no. files rlimit > scripts/kvm/kvm_stat: Cleanup of platform detection > scripts/kvm/kvm_stat: Make cpu detection a function > scripts/kvm/kvm_stat: Rename _perf_event_open > scripts/kvm/kvm_stat: Introduce properties for providers > scripts/kvm/kvm_stat: Cleanup of TracepointProvider > scripts/kvm/kvm_stat: Cleanup cpu list retrieval > scripts/kvm/kvm_stat: Encapsulate filters variable > scripts/kvm/kvm_stat: Cleanup of Stats class > scripts/kvm/kvm_stat: Cleanup of Groups class > scripts/kvm/kvm_stat: Cleanup of Event class > scripts/kvm/kvm_stat: Group arch specific data > scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS > scripts/kvm/kvm_stat: Make tui function a class > scripts/kvm/kvm_stat: Fix output formatting > scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr > scripts/kvm/kvm_stat: Read event values as u64 > scripts/kvm/kvm_stat: Fix rlimit for unprivileged users > scripts/kvm/kvm_stat: Fixup filtering > scripts/kvm/kvm_stat: Add interactive filtering > scripts/kvm/kvm_stat: Add optparse description > > scripts/kvm/kvm_stat | 1161 ++++++++++++++++++++++++++++---------------------- > 1 file changed, 663 insertions(+), 498 deletions(-) > Thanks, looks great! Paolo