Re: [Qemu-devel] [PATCH v17 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 01/19/2016 06:06 AM, Igor Mammedov wrote:
> Add commands to query Virtual Machine Generation ID counter.
> 
> QMP command example:
>     { "execute": "query-vm-generation-id" }
> 
> HMP command example:
>     info vm-generation-id
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>


> +++ b/qapi-schema.json
> @@ -4081,3 +4081,12 @@
>  ##
>  { 'enum': 'ReplayMode',
>    'data': [ 'none', 'record', 'play' ] }
> +
> +##
> +# @query-vm-generation-id
> +#
> +# Show Virtual Machine Generation ID
> +#
> +# Since 2.6
> +##
> +{ 'command': 'query-vm-generation-id', 'returns': 'UuidInfo' }

Nice reuse of an existing type, but maybe you want a followup patch to
make that type more generically worded (as it is no longer used _just_
for a UUID of the guest):

# @UuidInfo:
#
# Guest UUID information.
#
# @UUID: the UUID of the guest


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]