From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLzKb-0004Qm-JW for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLzKa-0003oV-NI for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:26:17 -0500 References: <1453314561-10486-1-git-send-email-mreitz@redhat.com> <1453314561-10486-3-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <569FED60.6040307@redhat.com> Date: Wed, 20 Jan 2016 13:26:08 -0700 MIME-Version: 1.0 In-Reply-To: <1453314561-10486-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2XmrxXSphItJeWoV8eFRxAKiWICuSecP0" Subject: Re: [Qemu-devel] [PATCH v2 2/4] blockdev: Fix 'change' for slot devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Peter Maydell , Alberto Garcia , qemu-stable , qemu-devel@nongnu.org, Markus Armbruster , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2XmrxXSphItJeWoV8eFRxAKiWICuSecP0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/20/2016 11:29 AM, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices= > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required it to return true. >=20 > Fix this by making blockdev-{insert,remove}-medium work on tray-less > devices. Also, blockdev-{open,close}-tray are now explicitly no-ops whe= n > invoked on such devices, and blk_dev_change_media_cb() is instead > called by blockdev-{insert,remove}-medium (for tray-less devices only).= >=20 > Reported-by: Peter Maydell > Cc: qemu-stable > Signed-off-by: Max Reitz > --- > blockdev.c | 31 +++++++++++++++++++++++++++++-- > qapi/block-core.json | 3 +-- > 2 files changed, 30 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2XmrxXSphItJeWoV8eFRxAKiWICuSecP0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWn+1gAAoJEKeha0olJ0Nqia8H/3zJ//yy+G9u+zXP+CtCPrAz 1G4jF/soW+naF8W2PRxAF4kl+flnGX9EAZTgKjxVAJVymy/5uq4DoeihwqpNQy82 aMoFU6aBTNjqHWnANYLALkkSSoI5+si8CF6hB1TwtJ6hH18H9pGF59TaQDynCydZ 88pHz0tlfwWGyU1NF/sAUENfhm8RvHw0+9OnpmW+p+3eo7iPYBN0IXvl59ai7ith r/+tF+ltnH2g8XKs1cf/GrR+Kt7KSGPDTMTu8PKC5wVp76C9vBXO4z+ciSBCWHVg I/qCgqTYI8HBHgmdkY1B3k7QUzvVniu7taiRRQp1pIvGL+APByHb7MxgL7bSwu8= =6eh7 -----END PGP SIGNATURE----- --2XmrxXSphItJeWoV8eFRxAKiWICuSecP0--