From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLzOv-0006Yb-7o for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:30:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLzOu-0004bK-7q for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:30:45 -0500 References: <1453272694-17106-1-git-send-email-jsnow@redhat.com> <1453272694-17106-3-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <569FEE6D.5020407@redhat.com> Date: Wed, 20 Jan 2016 13:30:37 -0700 MIME-Version: 1.0 In-Reply-To: <1453272694-17106-3-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9gJlJoKPg4CWfTXudd1EqQ5CBIIxo6X7I" Subject: Re: [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9gJlJoKPg4CWfTXudd1EqQ5CBIIxo6X7I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2016 11:51 PM, John Snow wrote: > Modify this function to operate directly on FDrive objects instead of > unpacking and passing all of those parameters manually. Reduces the > complexity in the caller and reduces the number of args to just one. >=20 > Signed-off-by: John Snow > --- > hw/block/fdc.c | 50 ++++++++++++++++++++------------------------------= > 1 file changed, 20 insertions(+), 30 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9gJlJoKPg4CWfTXudd1EqQ5CBIIxo6X7I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWn+5tAAoJEKeha0olJ0NqdN0H/0gSpqmZMirVxNmxFUGAMTHk rVNR8Ib+wyes6KJq8LR/iN0oFHe0Nk2SXbr960gczM36FVSo0u7mbd0muLydRD+h 8oK9ss72QgJFx/icP2PtBw01nqL9OagY5dZM1dWRwRX4UX6z19emc7pl0ziRLnGU qoyvpbkXKvTSFyQMCpXRRtj9wM0OjKYoxhCQfrMjSqhboF35gf4w98+dmlsMKPZq s5nEgYsOXfgvooeGVuIYjsqwuTq0+4jYqRZoLMj7YqYnhoWkWyStPEoLofqYPzZW Ic9PYRCYb1Mko8tAQ8TZ4SGbaiKBxCatIfFDEAgzQcublfhYZ1Auwm1dcE9tMlk= =/r7D -----END PGP SIGNATURE----- --9gJlJoKPg4CWfTXudd1EqQ5CBIIxo6X7I--