From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 03/12] fdc: add drive type qapi enum
Date: Wed, 20 Jan 2016 13:33:48 -0700 [thread overview]
Message-ID: <569FEF2C.3050402@redhat.com> (raw)
In-Reply-To: <1453272694-17106-4-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
On 01/19/2016 11:51 PM, John Snow wrote:
> Change the floppy drive type to a QAPI enum type, to allow us to
> specify the floppy drive type from the CLI in a forthcoming patch.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> hw/block/fdc.c | 80 +++++++++++++++++++++++++-------------------------
> hw/i386/pc.c | 17 ++++++-----
> include/hw/block/fdc.h | 9 +-----
> qapi/block.json | 16 ++++++++++
> 4 files changed, 66 insertions(+), 56 deletions(-)
>
> +++ b/qapi/block.json
> @@ -40,6 +40,22 @@
> 'data': ['auto', 'none', 'lba', 'large', 'rechs']}
>
> ##
> +# @FloppyDriveType
> +#
> +# Type of Floppy drive to be emulated by the Floppy Disk Controller.
> +#
> +# @144: 1.44MB 3.5" drive
> +# @288: 2.88MB 3.5" drive
> +# @120: 1.5MB 5.25" drive
Umm, how does 120 match with 1.5M? Elsewhere the code comments say:
/* 1.2 MB 5"1/4 floppy disks */
With the typo fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-20 20:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 6:51 [Qemu-devel] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 01/12] fdc: move pick_geometry John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments John Snow
2016-01-20 20:30 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 03/12] fdc: add drive type qapi enum John Snow
2016-01-20 20:33 ` Eric Blake [this message]
2016-01-20 20:49 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 04/12] fdc: add disk field John Snow
2016-01-20 20:35 ` Eric Blake
2016-01-20 20:59 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 05/12] fdc: Throw an assertion on misconfigured fd_formats table John Snow
2016-01-20 21:23 ` Eric Blake
2016-01-20 21:33 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 06/12] fdc: add pick_drive John Snow
2016-01-20 22:30 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 07/12] fdc: Add fallback option John Snow
2016-01-20 22:36 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 08/12] fdc: add drive type option John Snow
2016-01-20 22:43 ` Eric Blake
2016-01-20 23:04 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 09/12] fdc: add physical disk sizes John Snow
2016-01-20 22:48 ` Eric Blake
2016-01-20 23:06 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 10/12] fdc: rework pick_geometry John Snow
2016-01-20 23:45 ` Eric Blake
2016-01-21 20:14 ` John Snow
2016-01-21 20:58 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 11/12] qtest/fdc: Support for 2.88MB drives John Snow
2016-01-21 17:40 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 12/12] fdc: change auto fallback drive for ISA FDC to 288 John Snow
2016-01-21 17:41 ` Eric Blake
2016-01-20 7:55 ` [Qemu-devel] [Qemu-block] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support Denis V. Lunev
2016-01-20 19:40 ` John Snow
2016-01-20 19:43 ` Denis V. Lunev
2016-01-21 10:53 ` Roman Kagan
2016-01-21 14:59 ` John Snow
2016-01-21 15:37 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FEF2C.3050402@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).