From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37875)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aMCLN-0006Zz-OZ
	for qemu-devel@nongnu.org; Thu, 21 Jan 2016 05:19:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aMCLK-0006i1-Iy
	for qemu-devel@nongnu.org; Thu, 21 Jan 2016 05:19:57 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1453340463-7654-1-git-send-email-david@gibson.dropbear.id.au>
	<56A038FE.4060700@ozlabs.ru> <20160121035020.GK27454@voom.redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56A0B0C7.90404@redhat.com>
Date: Thu, 21 Jan 2016 11:19:51 +0100
MIME-Version: 1.0
In-Reply-To: <20160121035020.GK27454@voom.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pseries: Allow TCG h_enter to work with
	hotplugged memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>, Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com



On 21/01/2016 04:50, David Gibson wrote:
> On Thu, Jan 21, 2016 at 12:48:46PM +1100, Alexey Kardashevskiy
> wrote:
>> On 01/21/2016 12:41 PM, David Gibson wrote:
>>> The implementation of the H_ENTER hypercall for PAPR guests
>>> needs to enforce correct access attributes on the inserted
>>> HPTE.  This means determining if the HPTE's real address is a
>>> regular RAM address (which requires attributes for coherent
>>> access) or an IO address (which requires attributes for
>>> cache-inhibited access).
>>> 
>>> At the moment this check is implemented with (raddr <
>>> machine->ram_size), but that only handles addresses in the base
>>> RAM area, not any hotplugged RAM.
>>> 
>>> This patch corrects the problem with a new helper.
>>> 
>>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>> 
>> 
>> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> 
> Thanks, merged to ppc-for-2.6.

Can you still remove the Pascal parentheses? :)

Paolo