From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMHcW-00006Q-R1 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 10:58:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMHcV-00022X-Uy for qemu-devel@nongnu.org; Thu, 21 Jan 2016 10:58:00 -0500 References: <1452218894-2388-1-git-send-email-famz@redhat.com> <1452218894-2388-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56A10000.70002@redhat.com> Date: Thu, 21 Jan 2016 16:57:52 +0100 MIME-Version: 1.0 In-Reply-To: <1452218894-2388-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O8evALMD6Dj3HoiMBAcSIEUEoH9Hb14KA" Subject: Re: [Qemu-devel] [PATCH v6 01/15] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O8evALMD6Dj3HoiMBAcSIEUEoH9Hb14KA Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.01.2016 03:08, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. Its value should be ignored unless > BDRV_BLOCK_OFFSET_VALID in ret is set. >=20 > Until block drivers fill in the right value, let's clear it explicitly > right before calling .bdrv_get_block_status. >=20 > The "bs->file" condition in bdrv_co_get_block_status is kept now to kee= p iotest > case 102 passing, and will be fixed once all drivers return the right f= ile > pointer. >=20 > Signed-off-by: Fam Zheng > --- > block/io.c | 38 ++++++++++++++++++++++++++------------ > block/iscsi.c | 6 ++++-- > block/mirror.c | 3 ++- > block/parallels.c | 2 +- > block/qcow.c | 2 +- > block/qcow2.c | 2 +- > block/qed.c | 3 ++- > block/raw-posix.c | 3 ++- > block/raw_bsd.c | 3 ++- > block/sheepdog.c | 2 +- > block/vdi.c | 2 +- > block/vmdk.c | 2 +- > block/vpc.c | 2 +- > block/vvfat.c | 2 +- > include/block/block.h | 11 +++++++---- > include/block/block_int.h | 3 ++- > qemu-img.c | 7 +++++-- > 17 files changed, 60 insertions(+), 33 deletions(-) Patch itself is good, but the two bdrv_get_block_status_above() calls you added in qemu-img.c in 25ad8e6e need to be amended now, too. Max --O8evALMD6Dj3HoiMBAcSIEUEoH9Hb14KA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWoQAAAAoJEDuxQgLoOKyt97IH/2YoqVN5aAQCqa4RevgkSkKE kvByji/TB04Uto/OtFl/uebXHdCvv+uJsby43VegRvNt+HjS3zbIe/uCOl0DFBJ/ C0N4etR5JqJvQyMLt08MdJAsSko+o29PpLKrkltMlmB+TiTdmSnOLkGduINn+sO5 9FQjkh+IFWaj6SKZ4Fanup60aBxnSTuvaCuKc0brO55ZDW8VolpKC7BnO4/O6Ele f9VOx3kIq7RV0u99JIZBVJxV9pLeWVAMYFoUpXAEWdOe4F1M2EHUlqflSrYr26VM 7jF+5t3YJjF+1Ag7rjO6Uji/deWa0jhvmAmBqn1J2adpG85ShfXPK+e/TIbfGgk= =dzMv -----END PGP SIGNATURE----- --O8evALMD6Dj3HoiMBAcSIEUEoH9Hb14KA--