From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMHv9-00026o-VM for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:17:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMHv5-0006jU-PX for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:17:15 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:58231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMHv5-0006j6-G0 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:17:11 -0500 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Jan 2016 16:17:07 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 29B1717D805D for ; Thu, 21 Jan 2016 16:17:12 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0LGH6DW9044290 for ; Thu, 21 Jan 2016 16:17:06 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0LGH5EO023176 for ; Thu, 21 Jan 2016 09:17:05 -0700 References: <1449144881-130935-1-git-send-email-borntraeger@de.ibm.com> <5697B045.4060500@de.ibm.com> From: Christian Borntraeger Message-ID: <56A10481.1020009@de.ibm.com> Date: Thu, 21 Jan 2016 17:17:05 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] gdb: provide the name of the architecture in the target.xml List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Cornelia Huck , David Hildenbrand , qemu-devel On 01/15/2016 03:18 PM, Peter Maydell wrote: > On 14 January 2016 at 14:27, Christian Borntraeger > wrote: >> Ping? >> >> On 12/03/2015 01:14 PM, Christian Borntraeger wrote: >>> From: David Hildenbrand >>> >>> This patch provides the name of the architecture in the target.xml >>> if available. >>> >>> This allows the remote gdb to detect the target architecture on its >>> own - so there is no need to specify it manually (e.g. if gdb is >>> started without a binary) using "set arch *arch_name*". >>> >>> The name of the architecture is provided by a callback that can >>> be implemented by all architectures. The arm implementation has >>> special handling for iwmmxt and returns arm otherwise. This can >>> be extended if necessary. >>> >>> Signed-off-by: David Hildenbrand >>> Acked-by: Cornelia Huck >>> Signed-off-by: Christian Borntraeger >>> [rework to use a callback] >>> --- >>> v1->v2: replace the fixed string with a callback >>> >>> gdbstub.c | 21 ++++++++++++++------- >>> include/qom/cpu.h | 3 +++ >>> target-arm/cpu.c | 12 ++++++++++++ >>> target-arm/cpu64.c | 6 ++++++ >>> target-ppc/translate_init.c | 10 ++++++++++ >>> target-s390x/cpu.c | 6 ++++++ >>> 6 files changed, 51 insertions(+), 7 deletions(-) > > Reviewed-by: Peter Maydell > > (at least for the generic and ARM related bits). Ok, so I will take that and send it via the s390/kvm tree? Well, Conny will probably do the next round. Christian