From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMIJb-0005Sm-Ka for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:42:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMIJY-0005ag-OB for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:42:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMIJY-0005aa-IJ for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:42:28 -0500 References: <1453377386-10190-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56A10A72.7050809@redhat.com> Date: Thu, 21 Jan 2016 09:42:26 -0700 MIME-Version: 1.0 In-Reply-To: <1453377386-10190-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qRSWHIj2j9KMffI6cMVBh4nWpDFAtoe1R" Subject: Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qRSWHIj2j9KMffI6cMVBh4nWpDFAtoe1R Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/21/2016 04:56 AM, Daniel P. Berrange wrote: > The gd_vc_handler() callback is using g_malloc0() to > allocate the CharDriverState struct. As a result the > logfd field is getting initialized to 0, instead of > -1 when no logfile is requested. >=20 > The result is that when running >=20 > $ qemu-system-i386 -nodefaults -chardev vc,id=3Dmon0 -mon chardev=3Dmo= n0 >=20 > qemu duplicates all monitor output to stdout as well > as the GTK window. >=20 > Not using qemu_chr_alloc() was already a bug, but harmless > until this commit >=20 > commit d0d7708ba29cbcc343364a46bff981e0ff88366f > Author: Daniel P. Berrange > Date: Mon Jan 11 12:44:41 2016 +0000 >=20 > qemu-char: add logfile facility to all chardev backends >=20 > which exposed the problem as a behaviour regression >=20 > Reported-by: Herv=C3=A9 Poussineau > Signed-off-by: Daniel P. Berrange > --- > ui/gtk.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qRSWHIj2j9KMffI6cMVBh4nWpDFAtoe1R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWoQpyAAoJEKeha0olJ0NqafoH/0aUG51+pacKofQ9yCw7cV4A q2a8TXKpH+xNBjU9JBkGc1WJk/toGNmLvYK0Dxp+Yfh7wjhI+otVcwXyiQPVMfgW nghiDPT3L36f40Am/ahNFD2KzhNatCW9eXRjuhnEh1n0iKrrup67jg9hjTfURoE3 Rqvv19gbVMjK2pIy5uLEhQDTSUep4rqdZpp2xosMeFodYhGwBYW4KMqhd9wdtG+n dKYNNNKFh0Y/fXSmLaN5WcFMcPiBDt/oKvHJPCgTxQMyOPozuKN89snj1G40xw/u 6Y1MnjvckvMO8aCAC1bXJvQ2ILdxXOS9DOPowyxPll9NZijtltTx661GItydeYM= =R8bF -----END PGP SIGNATURE----- --qRSWHIj2j9KMffI6cMVBh4nWpDFAtoe1R--