From: "Hervé Poussineau" <hpoussin@reactos.org>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState
Date: Thu, 21 Jan 2016 19:38:44 +0100 [thread overview]
Message-ID: <56A125B4.7050700@reactos.org> (raw)
In-Reply-To: <1453377386-10190-1-git-send-email-berrange@redhat.com>
Le 21/01/2016 12:56, Daniel P. Berrange a écrit :
> The gd_vc_handler() callback is using g_malloc0() to
> allocate the CharDriverState struct. As a result the
> logfd field is getting initialized to 0, instead of
> -1 when no logfile is requested.
>
> The result is that when running
>
> $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0
>
> qemu duplicates all monitor output to stdout as well
> as the GTK window.
>
> Not using qemu_chr_alloc() was already a bug, but harmless
> until this commit
>
> commit d0d7708ba29cbcc343364a46bff981e0ff88366f
> Author: Daniel P. Berrange <berrange@redhat.com>
> Date: Mon Jan 11 12:44:41 2016 +0000
>
> qemu-char: add logfile facility to all chardev backends
>
> which exposed the problem as a behaviour regression
>
> Reported-by: Hervé Poussineau <hpoussin@reactos.org>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Tested-by: Hervé Poussineau <hpoussin@reactos.org>
Hervé
next prev parent reply other threads:[~2016-01-21 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 11:56 [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState Daniel P. Berrange
2016-01-21 16:42 ` Eric Blake
2016-01-21 17:55 ` Peter Maydell
2016-01-21 18:38 ` Hervé Poussineau [this message]
2016-01-26 11:39 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A125B4.7050700@reactos.org \
--to=hpoussin@reactos.org \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).