From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMb0a-0000SS-SL for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:40:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMb0X-0005uU-LO for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:40:08 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMb0X-0005uG-DV for qemu-devel@nongnu.org; Fri, 22 Jan 2016 07:40:05 -0500 Received: by mail-wm0-x242.google.com with SMTP id 123so17045877wmz.2 for ; Fri, 22 Jan 2016 04:40:05 -0800 (PST) Sender: Paolo Bonzini References: <1453464520-3882-1-git-send-email-frankja@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <56A2231F.1030505@redhat.com> Date: Fri, 22 Jan 2016 13:39:59 +0100 MIME-Version: 1.0 In-Reply-To: <1453464520-3882-1-git-send-email-frankja@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] scripts/dump-guest-memory.py: Add multi-arch support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janosch Frank , qemu-devel@nongnu.org Cc: drjones@redhat.com, lersek@redhat.com On 22/01/2016 13:08, Janosch Frank wrote: > The dump guest memory script for extracting a Linux core from a qemu > core is currently limited to amd64 and python 2. > > With this series we add support for python 3 (while maintaining python > 2 support) and add the possibility to extract dumps from VMs with the > most common architectures. > > Tested on X86_64, s390 and Aarch64-le (thanks to Andrew Jones). > > RFC to PATCH: > Tested on X86_64 and Aarch64-le. > Fix wrongly indented return in get_guest_phys_blocks(). > Fix wrong indent for predecessor_size that happened when copying. > Fix inconsistent line wrapping. > Fix python 3 compatibility comment being added in the wrong commit. > Fix docstrings that get displayed by gdb. > Replaced ceil(len_desc / 4.0) with ((len_desc + 3) // 4) > Added patch that fixes module docstring to account for moved gdb > help string. > > Janosch Frank (6): > scripts/dump-guest-memory.py: Move constants to the top > scripts/dump-guest-memory.py: Make methods functions > scripts/dump-guest-memory.py: Improve python 3 compatibility > scripts/dump-guest-memory.py: Cleanup functions > scripts/dump-guest-memory.py: Introduce multi-arch support > scripts/dump-guest-memory.py: Fix module docstring > > scripts/dump-guest-memory.py | 754 +++++++++++++++++++++++++++---------------- > 1 file changed, 472 insertions(+), 282 deletions(-) > Queued, thanks. Paolo