From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMgys-0005ya-MI for qemu-devel@nongnu.org; Fri, 22 Jan 2016 14:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMgyo-0002ti-Jx for qemu-devel@nongnu.org; Fri, 22 Jan 2016 14:02:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMgyo-0002te-E7 for qemu-devel@nongnu.org; Fri, 22 Jan 2016 14:02:42 -0500 References: <1453464955-1601-1-git-send-email-valentin.rakush@gmail.com> From: Eric Blake Message-ID: <56A27CD0.8070701@redhat.com> Date: Fri, 22 Jan 2016 12:02:40 -0700 MIME-Version: 1.0 In-Reply-To: <1453464955-1601-1-git-send-email-valentin.rakush@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Uh6QUJLgVTUawjU1PLN3IDoXwq22KRPNL" Subject: Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Valentin Rakush , qemu-devel@nongnu.org Cc: armbru@redhat.com, lcapitulino@redhat.com, asmetanin@virtuozzo.com, den@openvz.org, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Uh6QUJLgVTUawjU1PLN3IDoXwq22KRPNL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/22/2016 05:15 AM, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. >=20 > Signed-off-by: Valentin Rakush > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Andreas F=C3=A4rber > Cc: Daniel P. Berrange > --- > +++ b/hmp-commands.hx > @@ -1734,6 +1734,19 @@ Print QOM properties of object at location @var{= path} > ETEXI > =20 > { > + .name =3D "qom-type-prop-list", To be consistent with most existing HMP commands, this should use qmp_type_prop_list (only the QMP version should use '-'). For that matter, should this really be a new top-level command, or should it be a subcommand of the 'info' command? The QMP command looks fine, though. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Uh6QUJLgVTUawjU1PLN3IDoXwq22KRPNL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWonzQAAoJEKeha0olJ0NqRRIH/3JI8R6AH8VoDExaRa+a8FQE FOLb19hFFBr5a0wRzRdIeA3RocJFk8W/6nndiAur86GhM1tLmQ63/YGj6BJaP3ZD p5h7pV/Ohgkbvv75015JjYlnQSx90nxmbbePQA/NJ5HaJvpsx06sIA27DlF46RZR /3IRKVEsUPVQIsjWbvkfCXatTd8HuZxkoC70MfUlTqTPih4u2V4pQGElnPh2XLkA ufopO8TI7cPqDrohQ4eZwiVlsK0ej8fIk58871m1pJif00GRz5GlL83ro+5uC5xZ I+fYUMI2sVQ4lFJHF43ixlT0mKX2SKonxkd4/edhnMafo8YbV95IkFDhkUJGAiE= =qMfV -----END PGP SIGNATURE----- --Uh6QUJLgVTUawjU1PLN3IDoXwq22KRPNL--