From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMkLs-0002Gu-1P for qemu-devel@nongnu.org; Fri, 22 Jan 2016 17:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMkLr-0001Cf-3o for qemu-devel@nongnu.org; Fri, 22 Jan 2016 17:38:43 -0500 References: <1452274665-23061-1-git-send-email-pbonzini@redhat.com> <56A23621.1010406@redhat.com> From: Max Reitz Message-ID: <56A2AF6A.5090004@redhat.com> Date: Fri, 22 Jan 2016 23:38:34 +0100 MIME-Version: 1.0 In-Reply-To: <56A23621.1010406@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GbQNdOw14F4EvquRGLFOJMJc6uSfxQpuK" Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Early release of -drive QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GbQNdOw14F4EvquRGLFOJMJc6uSfxQpuK Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 22.01.2016 15:01, Paolo Bonzini wrote: >=20 >=20 > On 08/01/2016 18:37, Paolo Bonzini wrote: >> In short, this patch gets rid of blockdev_mark_auto_del and >> blockdev_auto_del. >> >> With these patches, it is possible to create a new -drive with the sam= e >> id as soon as the DEVICE_DELETED event is delivered (which equals to >> unrealize). >> >> I'm sorry I'm not able to explain the history (and probably do not >> understand the full ramifications) of this. That's why this is just >> an RFC. >> >> The idea here is that reference counting the BlockBackend is enough to= >> defer the deletion of the block device as much as necessary; anticipat= ing >> the demise of the DriveInfo is not a problem, and has the desired effe= ct >> of freeing the QemuOpts. >> >> Paolo >> >> Paolo Bonzini (2): >> block: detach devices from DriveInfo at unrealize time >> block: remove legacy_dinfo at blk_detach_dev time >> >> block/block-backend.c | 14 ++++++++---- >> blockdev.c | 26 ++++++++------------------ >> hw/block/virtio-blk.c | 4 +++- >> hw/block/xen_disk.c | 1 + >> hw/core/qdev-properties-system.c | 2 +- >> hw/ide/piix.c | 3 +++ >> hw/scsi/scsi-bus.c | 4 +++- >> hw/usb/dev-storage.c | 3 ++- >> include/sysemu/blockdev.h | 5 ++--- >> 9 files changed, 33 insertions(+), 29 deletions(-) >> >=20 > Ping? Any comments or other kinds of review? :) I skimmed it last week and I remember that I found the idea sound and didn't have any objections; but that I didn't feel confident for a R-b or explicit comment, because I don't think I understand the full ramifications of it either. ;-) Max --GbQNdOw14F4EvquRGLFOJMJc6uSfxQpuK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWoq9rAAoJEDuxQgLoOKytukUH/j850FD+7XDPkUx5c0ZVmyh2 4fqK3WFTDdUIje5dXOkkS++1n1C+o+G4bWccQtcAJcSPbTyZaKo+mKlclgy1clCl M/mcmjeenDOAhjG6O8O8bfEhXYPEuPV4KbYXfaICbQT7nQpK9ZnAM9y2UBZXEJpJ G5/W1bYiVNJTwB/NChzkSqn0uZIWf36KInGuIk7+NIFrXvhNGk0NC5vSoN+nv0EY KMPd2UlnZUUimrk9ViOkFCFhFYcQTr2uk5ZJrprBeQtv6lr25zu2PP5W2RVd2/Ha OWmxJmL1MgqvDICwTsq5myQNAVwWKBgjE0zZG81uNhX/OgtEwqK8JSfzRVKFy2k= =zqjR -----END PGP SIGNATURE----- --GbQNdOw14F4EvquRGLFOJMJc6uSfxQpuK--