From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhTG-0000an-OU for qemu-devel@nongnu.org; Mon, 25 Jan 2016 08:46:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNhTC-0002e2-OH for qemu-devel@nongnu.org; Mon, 25 Jan 2016 08:46:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhTC-0002ds-JY for qemu-devel@nongnu.org; Mon, 25 Jan 2016 08:46:14 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 07A038E69C for ; Mon, 25 Jan 2016 13:46:13 +0000 (UTC) References: <1453728801-5398-1-git-send-email-stefanha@redhat.com> <1453728801-5398-3-git-send-email-stefanha@redhat.com> From: Paolo Bonzini Message-ID: <56A62722.5040801@redhat.com> Date: Mon, 25 Jan 2016 14:46:10 +0100 MIME-Version: 1.0 In-Reply-To: <1453728801-5398-3-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-blk: drop unused migration.h include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org On 25/01/2016 14:33, Stefan Hajnoczi wrote: > The migration blocker functionality is no longer necessary since > dataplane is now compatible with live migration. Drop the unused header > include. > > Signed-off-by: Stefan Hajnoczi > --- > This patch can be squashed into "virtio-blk: do not use vring in > dataplane". > --- > hw/block/virtio-blk.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 1106d13..3e34d35 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -20,7 +20,6 @@ > #include "sysemu/blockdev.h" > #include "hw/virtio/virtio-blk.h" > #include "dataplane/virtio-blk.h" > -#include "migration/migration.h" > #include "block/scsi.h" > #ifdef __linux__ > # include > Great, I'll check if the same is needed for hw/scsi/virtio-scsi.c. Paolo