From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhri-0001uT-Ju for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:11:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNhrh-00084q-EB for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:11:34 -0500 References: <1453689887-2567-1-git-send-email-famz@redhat.com> <1453689887-2567-16-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56A62D0A.7020704@redhat.com> Date: Mon, 25 Jan 2016 15:11:22 +0100 MIME-Version: 1.0 In-Reply-To: <1453689887-2567-16-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MUCecuqO8HBUJktKS5l7AgJwlTe475EG6" Subject: Re: [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MUCecuqO8HBUJktKS5l7AgJwlTe475EG6 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 25.01.2016 03:44, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/059 | 10 ++++++++++ > tests/qemu-iotests/059.out | 26 ++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) >=20 > diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 > index 0ded0c3..0332bbb 100755 > --- a/tests/qemu-iotests/059 > +++ b/tests/qemu-iotests/059 > @@ -133,6 +133,16 @@ $QEMU_IO -c "write -P 0xa 900G 512" "$TEST_IMG" | = _filter_qemu_io > $QEMU_IO -c "read -v 900G 1024" "$TEST_IMG" | _filter_qemu_io > =20 > echo > +echo "=3D=3D=3D Testing qemu-img map on extents =3D=3D=3D" > +for fmt in monolithicSparse twoGbMaxExtentSparse; do > + IMGOPTS=3D"subformat=3D$fmt" _make_test_img 31G > + $QEMU_IO -c "write 65024 1k" "$TEST_IMG" | _filter_qemu_io > + $QEMU_IO -c "write 2147483136 1k" "$TEST_IMG" | _filter_qemu_io > + $QEMU_IO -c "write 5G 1k" "$TEST_IMG" | _filter_qemu_io > + $QEMU_IMG map "$TEST_IMG" | _filter_testdir > +done > + > +echo > echo "=3D=3D=3D Testing afl image with a very large capacity =3D=3D=3D= " > _use_sample_img afl9.vmdk.bz2 > _img_info > diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out > index 9d506cb..5e041d7 100644 > --- a/tests/qemu-iotests/059.out > +++ b/tests/qemu-iotests/059.out > @@ -2050,6 +2050,7 @@ wrote 512/512 bytes at offset 0 > 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > wrote 512/512 bytes at offset 10240 > 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +qemu-img: Could not open '/home/fam/build/last/tests/qemu-iotests/scra= tch/t.vmdk': VMDK version 3 must be read only I'd rather have the test fail than include this apparently wrong line (according to http://lists.nongnu.org/archive/html/qemu-block/2016-01/msg00710.html) here, but I'll leave that up to you. Reviewed-by: Max Reitz > =20 > =3D=3D=3D Testing monolithicFlat with internally generated JSON file n= ame =3D=3D=3D > Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 subformat= =3DmonolithicFlat > @@ -2335,6 +2336,31 @@ e1000003f0: 00 00 00 00 00 00 00 00 00 00 00 00= 00 00 00 00 ................ > read 1024/1024 bytes at offset 966367641600 > 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > =20 > +=3D=3D=3D Testing qemu-img map on extents =3D=3D=3D > +Formatting 'TEST_DIR/iotest-version3.IMGFMT', fmt=3DIMGFMT size=3D3328= 5996544 subformat=3DmonolithicSparse > +wrote 1024/1024 bytes at offset 65024 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +wrote 1024/1024 bytes at offset 2147483136 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +wrote 1024/1024 bytes at offset 5368709120 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +Offset Length Mapped to File > +0 0x20000 0x3f0000 TEST_DIR/iotest-versio= n3.vmdk > +0x7fff0000 0x20000 0x410000 TEST_DIR/iotest-versio= n3.vmdk > +0x140000000 0x10000 0x430000 TEST_DIR/iotest-versio= n3.vmdk > +Formatting 'TEST_DIR/iotest-version3.IMGFMT', fmt=3DIMGFMT size=3D3328= 5996544 subformat=3DtwoGbMaxExtentSparse > +wrote 1024/1024 bytes at offset 65024 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +wrote 1024/1024 bytes at offset 2147483136 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +wrote 1024/1024 bytes at offset 5368709120 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +Offset Length Mapped to File > +0 0x20000 0x50000 TEST_DIR/iotest-versio= n3-s001.vmdk > +0x7fff0000 0x10000 0x70000 TEST_DIR/iotest-versio= n3-s001.vmdk > +0x80000000 0x10000 0x50000 TEST_DIR/iotest-versio= n3-s002.vmdk > +0x140000000 0x10000 0x50000 TEST_DIR/iotest-versio= n3-s003.vmdk > + > =3D=3D=3D Testing afl image with a very large capacity =3D=3D=3D > qemu-img: Can't get size of device 'image': File too large > *** done >=20 --MUCecuqO8HBUJktKS5l7AgJwlTe475EG6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWpi0KAAoJEDuxQgLoOKytWhsH/0E6rW0khRYTGEs+1LV5dw+Q 2SrsUIHJO4yFjzvXXMXtpjk0WZSpQ3A6cyjL2V6Rh9CGCzOSZwyoRPc+UrqYjxeE xJ77of2Dko3zm36v/flHoWU7VkcqhWjyVNJ590RMeP2sb4CU5XIEQ+iVANc0K0rA 3lukNMAYfunWi7+JnM45G5fUI/a9av5Mc0tkRW+SXNJswNvBGyzIAV9ExK9MjMoG gr+o9+lUguXLuR5G/tgKO91EV4RUfJubVEVi5EVmrBcV0GbQX6oAOHNBNl1uvJ61 OL+VG0vb+G2q+CP5Pl1E9xB6hoIeBLaOJtyaGblkkpIMKA6mm1/gJ1jcxLYSNLQ= =d1hh -----END PGP SIGNATURE----- --MUCecuqO8HBUJktKS5l7AgJwlTe475EG6--