From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aNiV8-0005Jd-Aj
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:52:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aNiV6-0000gs-4D
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:52:18 -0500
Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:32856)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aNiV4-0000gd-R1
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:52:16 -0500
Received: by mail-wm0-x234.google.com with SMTP id 123so68729640wmz.0
	for <qemu-devel@nongnu.org>; Mon, 25 Jan 2016 06:52:14 -0800 (PST)
References: <1453130204-655-1-git-send-email-eric.auger@linaro.org>
	<1453130204-655-7-git-send-email-eric.auger@linaro.org>
	<CAFEAcA9ZximjpaZ_rSdfM1JRyhW9dz1DZfcRRqQR+03heSPg2A@mail.gmail.com>
	<56A62CAD.50405@linaro.org>
	<CAFEAcA9+31D4yGnYr6DgQQLfSmp3wMiLLhuX07sje0oBRiLEFg@mail.gmail.com>
	<CAFEAcA-ByZWz0mpbVJTTsSzyn24M_DnREptu73w=UUtiHK69Hg@mail.gmail.com>
From: Eric Auger <eric.auger@linaro.org>
Message-ID: <56A6368C.5000409@linaro.org>
Date: Mon, 25 Jan 2016 15:51:56 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-ByZWz0mpbVJTTsSzyn24M_DnREptu73w=UUtiHK69Hg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for
 clock node generation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>, Thomas Huth <thuth@redhat.com>, eric.auger@st.com, Patch Tracking <patches@linaro.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, qemu-arm <qemu-arm@nongnu.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, thomas.lendacky@amd.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, David Gibson <david@gibson.dropbear.id.au>

On 01/25/2016 03:43 PM, Peter Maydell wrote:
> On 25 January 2016 at 14:34, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 25 January 2016 at 14:09, Eric Auger <eric.auger@linaro.org> wrote:
>>> Hi Peter,
>>> On 01/25/2016 03:05 PM, Peter Maydell wrote:
>>>> On 18 January 2016 at 15:16, Eric Auger <eric.auger@linaro.org> wrote:
>>
>>>> Don't we want to return here, rather than continuing with the
>>>> rest of the function? ("goto err;" with an err: label before
>>>> the g_free() at the bottom of the function probably best since
>>>> some of the error paths need to free that.)
>>> due to the &error_fatal, we are going to exit here. I thought it is not
>>> worth going further if we can't find the clock node.
>>
>> Yes, sorry, I didn't notice the error_fatal til I got to about
>> the last patch I reviewed. You can ignore similar comments
>> I made about some of the other patches.
> 
> ...so if you fix the 'asserts' comment thing, you can have
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

OK thanks for the whole review

Eric
> 
> thanks
> -- PMM
>