From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOSgL-0003zu-A9 for qemu-devel@nongnu.org; Wed, 27 Jan 2016 11:10:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOSgF-0001m0-Bi for qemu-devel@nongnu.org; Wed, 27 Jan 2016 11:10:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOSgF-0001lo-4p for qemu-devel@nongnu.org; Wed, 27 Jan 2016 11:10:51 -0500 References: <1453798787-7453-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <56A812E9.9030006@huawei.com> From: Eric Blake Message-ID: <56A8EC09.8070906@redhat.com> Date: Wed, 27 Jan 2016 09:10:49 -0700 MIME-Version: 1.0 In-Reply-To: <56A812E9.9030006@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VVvqtHfVLAm3anJtL1oTHIMxSpwwsAs6D" Subject: Re: [Qemu-devel] [PATCH] net/traffic-mirrorer:Add traffic-mirroer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hailiang Zhang , Zhang Chen , qemu devel , Jason Wang Cc: Li Zhijian , Gui jianfeng , "eddie.dong" , peter.huangpeng@huawei.com, "Dr. David Alan Gilbert" , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VVvqtHfVLAm3anJtL1oTHIMxSpwwsAs6D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2016 05:44 PM, Hailiang Zhang wrote: > On 2016/1/26 16:59, Zhang Chen wrote: >> From: ZhangChen >> >> Traffic-mirrorer is a plugin of netfilter. >> It make qemu has ability to copy and mirror guest's >> net packet. we output packet to chardev. >> >> +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp) >> +{ >> + MirrorerState *s =3D FILTER_TRAFFIC_MIRRORER(nf); >> + >> + if (!s->outdev) { >> + error_setg(errp, "filter traffic mirrorer needs 'outdev' >> property set!" >> + "property set!"); >=20 > Duplicate 'property set!'. For that matter, error_setg() messages should never end in '!'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VVvqtHfVLAm3anJtL1oTHIMxSpwwsAs6D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWqOwJAAoJEKeha0olJ0NqIGgH/jxdAtPwwW8iZiAj7uGos2lH GQM+MWh2AKZeJZqsNda5JF845sUpff+0/9CjTDxI3HaTQWGscr9VunE7vAIzZYyL xFKPIG9BcjwkxLDYBiF91xQRoDWPbGSIiQOfwl8WSKMHH8ITrwVcF3PYMjiTrtC5 uf+bhOPhIdniiZOJoMUb3cFlkK6yMOPsfdCuIQQbP/xJlV8DL/A7u9mVp5KzD9lV QCfGd8z+qbsO7E9n6BNl6ZlH38NEQag63vDRyNW3w1G71jxqyJJuO/aq0efP3jWL tdHOUthtRNoGQ+iq19LSNX1eI4SNq5LVfcduFlgDvRsjvsTGZBSLJDmrVBhg4I0= =otnT -----END PGP SIGNATURE----- --VVvqtHfVLAm3anJtL1oTHIMxSpwwsAs6D--