From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, P J P <ppandit@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Prasad J Pandit <pjp@fedoraproject.org>,
Zuozhi fzz <zuozhi.fzz@alibaba-inc.com>
Subject: Re: [Qemu-devel] [PATCH v2] ide: ahci: add check before calling dma_memory_unmap
Date: Thu, 28 Jan 2016 21:41:59 +0100 [thread overview]
Message-ID: <56AA7D17.8040903@redhat.com> (raw)
In-Reply-To: <56AA72A8.4040302@redhat.com>
On 28/01/2016 20:57, John Snow wrote:
> This is fine for now as it protects us against doing something stupid in
> a mechanical fashion, but I still wonder under which case we are
> "starting" the FIS or CLB engines without getting a valid address. (The
> unmap should only be happening when we /stop/ the engines, which implies
> they were started -- which points to a bug somewhere else, too.)
It can happen if both of them are registered to an MMIO address. The
second map will fail.
Perhaps it's a better fix to switch FIS and CLB to
address_space_read/write, but this works as a simple fix for the SEGV.
Paolo
prev parent reply other threads:[~2016-01-28 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:48 [Qemu-devel] [PATCH v2] ide: ahci: add check before calling dma_memory_unmap P J P
2016-01-28 19:57 ` John Snow
2016-01-28 20:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA7D17.8040903@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zuozhi.fzz@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).