From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aOuOF-0001LS-H3
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 16:46:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aOuOC-0002Hj-BS
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 16:46:07 -0500
References: <145401727502.31479.11571397180565966513.stgit@localhost>
	<145401729734.31479.15887562149880928240.stgit@localhost>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56AA8C16.3090602@redhat.com>
Date: Thu, 28 Jan 2016 14:45:58 -0700
MIME-Version: 1.0
In-Reply-To: <145401729734.31479.15887562149880928240.stgit@localhost>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R"
Subject: Re: [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new
 error_report_abort() instead of abort()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, "open list:Overall" <kvm@vger.kernel.org>, Stefan Hajnoczi <stefanha@gmail.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Alexander Graf <agraf@suse.de>, "open list:PowerPC" <qemu-ppc@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/28/2016 02:41 PM, Llu=C3=ADs Vilanova wrote:
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  target-ppc/kvm.c        |    4 ++--
>  target-ppc/kvm_ppc.h    |   15 +++++++++------
>  target-ppc/mmu-hash32.c |    5 +++--
>  target-ppc/mmu_helper.c |    3 +--
>  4 files changed, 15 insertions(+), 12 deletions(-)
>=20

> +++ b/target-ppc/kvm_ppc.h
> @@ -9,6 +9,9 @@
>  #ifndef __KVM_PPC_H__
>  #define __KVM_PPC_H__
> =20
> +#include "qemu/error-report.h"
> +
> +
>  #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU
> =20
>  #ifdef CONFIG_KVM
> @@ -220,36 +223,36 @@ static inline int kvmppc_get_htab_fd(bool write)
>  static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize=
,
>                                     int64_t max_ns)
>  {
> -    abort();
> +    error_report_abort(" ");

Aborting with an empty string with trailing spaces feels awkward.
Either this should be a real message, or abort() was just fine.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWqowWAAoJEKeha0olJ0Nqy14H+wVxmj7v+IAP28BBQ3TDhxAR
oCyFoxqPGoW5xZD6ufhlyW+dDVx5HJraaWE6S1kg9qigIcUuz5VHnL1UqphxSq9U
37bouxOrV0LK2lsg/TMKzsd9o0pkQcQhyzbNKs0ljMpdXiiSQT/kIdKoIOtir2xG
3MHIBCrdu5OJlzFF985uEMvBsrBdZkfuypuFaG2wCYQxglzbQJnw5CUR8eObEanw
Svf7YAMyZZeyOCIcnf2GVZ/7HPNClsjyirxwA511ORb0V6pCigTwsz/hVfNS04p0
bsSvskflur5Jy3TJHFzKcwPcH2mtjY+kHrSmcl8r9PFA+SRRIMM3QdzyKy1sgrQ=
=mxpV
-----END PGP SIGNATURE-----

--qB2pGxVBPsQ3Qj4ilGQGPAVMh9CD0BT0R--