From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51813)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aOudk-0001x4-Kj
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 17:02:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aOudg-0007fk-4q
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 17:02:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59055)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1aOudf-0007fX-Vl
	for qemu-devel@nongnu.org; Thu, 28 Jan 2016 17:02:04 -0500
References: <145401801194.13643.11789300006832270147.stgit@localhost>
	<145401803957.13643.4011946397351594395.stgit@localhost>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56AA8FD7.3070300@redhat.com>
Date: Thu, 28 Jan 2016 15:01:59 -0700
MIME-Version: 1.0
In-Reply-To: <145401803957.13643.4011946397351594395.stgit@localhost>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="4lQKjnFPreDX9FmRM4qwX6JFrsMIULr1T"
Subject: Re: [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for
	errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Thomas Huth <thuth@redhat.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4lQKjnFPreDX9FmRM4qwX6JFrsMIULr1T
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/28/2016 02:53 PM, Llu=C3=ADs Vilanova wrote:
> Gives some general guidelines for reporting errors in QEMU.
>=20
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  HACKING |   33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

I'm not sure if my v4 review crossed paths with this, but I still see typ=
os:

> +
> +WARNING: The special 'error_fatal' and 'error_abort' objects follow th=
e same
> +constrains as the 'error_report_fatal' and 'error_report_abort' functi=
ons.

s/constrains/constraints/

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--4lQKjnFPreDX9FmRM4qwX6JFrsMIULr1T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWqo/XAAoJEKeha0olJ0NqnooIAJ3AmZyoeXLb/h+B2/gdJ+26
wtnNpNJ0U/ziaRRUHiusnfwkCNnX80ZiLjd2YYxsrU6LPkkOEjhcS4EbgJPer2Zq
YcmXbOWKOZIFpAamPIMCjhTm296Jo201OBKuSPHCniIykBBoVoa8hoAni6blvMHb
BglhNzOh7DIDP6truIhnTT3DvjWPhpBQ2Kb7b4FVBkayOojiNCdV6ngN5cJjV8uU
8kV3rTw6B4wAiLNa3usrHri+Vtg5VBUsoKY/fuoM8cFzBuocft2hnx+3Qunp4yjt
Nr5HAVaqjUNaE30dz+3DoaMd4yWSZcosMN2Z4U73CdPv18oMmRVrTj0Hv6jLT3I=
=JApB
-----END PGP SIGNATURE-----

--4lQKjnFPreDX9FmRM4qwX6JFrsMIULr1T--