From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQAEO-0002mD-6G for qemu-devel@nongnu.org; Mon, 01 Feb 2016 03:53:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQAEK-0007z9-5k for qemu-devel@nongnu.org; Mon, 01 Feb 2016 03:53:08 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:33854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQAEJ-0007z3-SO for qemu-devel@nongnu.org; Mon, 01 Feb 2016 03:53:04 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Feb 2016 08:53:01 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 57B471B08076 for ; Mon, 1 Feb 2016 08:53:07 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u118qvGe7274942 for ; Mon, 1 Feb 2016 08:52:57 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u118qunL008484 for ; Mon, 1 Feb 2016 01:52:57 -0700 References: <1453913621-20961-1-git-send-email-mjrosato@linux.vnet.ibm.com> From: Christian Borntraeger Message-ID: <56AF1CE6.2010106@de.ibm.com> Date: Mon, 1 Feb 2016 09:52:54 +0100 MIME-Version: 1.0 In-Reply-To: <1453913621-20961-1-git-send-email-mjrosato@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato , qemu-devel@nongnu.org, afaerber@suse.de Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com, bharata@linux.vnet.ibm.com, agraf@suse.de, rth@twiddle.net On 01/27/2016 05:53 PM, Matthew Rosato wrote: > Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during s390_cpu_release to accomodate changes in > Patch 4 "Reclaim VCPU objects." > * Remove a cleanup patch in favor of 2 patches from pseries set. > > ************** > > The following patchset enables hotplug of s390 CPUs. > > The standard interface is used -- to configure a guest with 2 CPUs online at > boot and 4 maximum: > > qemu -smp 2,maxcpus=4 > > To subsequently hotplug a CPU: > > Issue 'device_add s390-cpu,id=' from monitor. > > At this point, the guest must bring the CPU online for use -- This can be > achieved via "echo 1 > /sys/devices/system/cpu/cpuX/online" or via a management > tool like cpuplugd. > > Hot unplug support is provided via 'device_del ', however s390 does not have > a mechanism for gracefully handling a CPU that has been removed, so this event > triggers a reset of the guest in order to force recognition. > > This patch set is based on work previously done by Jason Herne. > > Bharata B Rao (3): > exec: Remove cpu from cpus list during cpu_exec_exit() > exec: Do vmstate unregistration from cpu_exec_exit() > cpu: Add a sync version of cpu_remove() > > Gu Zheng (1): > cpu: Reclaim vCPU objects > > Matthew Rosato (6): > s390x/cpu: Cleanup init in preparation for hotplug > s390x/cpu: Set initial CPU state in common routine > s390x/cpu: Move some CPU initialization into realize > s390x/cpu: Add functions to (un)register CPU state > s390/virtio-ccw: Add hotplug handler and prepare for unplug > s390x/cpu: Allow hot plug/unplug of CPUs > > cpus.c | 50 +++++++++++++++++++++++++++++++++ > exec.c | 30 ++++++++++++++++++++ > hw/s390x/s390-virtio-ccw.c | 30 +++++++++++++++++++- > hw/s390x/s390-virtio.c | 64 +++++++++++++++++++++++++++++++----------- > hw/s390x/s390-virtio.h | 2 +- > include/qom/cpu.h | 18 ++++++++++++ > include/sysemu/kvm.h | 1 + > kvm-all.c | 57 ++++++++++++++++++++++++++++++++++++- > kvm-stub.c | 5 ++++ > target-s390x/cpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++--- > target-s390x/cpu.h | 4 +++ > 11 files changed, 308 insertions(+), 23 deletions(-) Acked-by: Christian Borntraeger Alexander, if you are too busy at the moment, we could carry these patches via the s390/kvm tree? We want these patches merged, since we have to libvirt as well to use device_add instead of cpu_add (sigh). Christian