From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, jcody@redhat.com
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] jobs: remove unused structure
Date: Mon, 1 Feb 2016 15:21:47 -0700 [thread overview]
Message-ID: <56AFDA7B.2010701@redhat.com> (raw)
In-Reply-To: <1454365097-18314-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On 02/01/2016 03:18 PM, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> blockjob.c | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/blockjob.c b/blockjob.c
> index 80adb9d..a692142 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
> }
> }
>
> -struct BlockFinishData {
> - BlockJob *job;
> - BlockCompletionFunc *cb;
> - void *opaque;
> - bool cancelled;
> - int ret;
> -};
> -
> static int block_job_finish_sync(BlockJob *job,
> void (*finish)(BlockJob *, Error **errp),
> Error **errp)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-01 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 22:18 [Qemu-devel] [PATCH] jobs: remove unused structure John Snow
2016-02-01 22:21 ` Eric Blake [this message]
2016-02-02 2:19 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFDA7B.2010701@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).