From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>, Wei Huang <wei@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
Shannon Zhao <shannon.zhao@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Shannon Zhao <zhaoshenglong@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state
Date: Tue, 2 Feb 2016 10:03:04 +0300 [thread overview]
Message-ID: <56B054A8.6020602@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA9XZHowe_JtGFcqEJpnZiqXwT+36bBPPKXWSgc1aVGtHg@mail.gmail.com>
01.02.2016 21:01, Peter Maydell wrote:
> On 1 February 2016 at 17:20, Wei Huang <wei@redhat.com> wrote:
>> This patch removes float_high field of PL061State, which doesn't seem
>> to be used anywhere.
[]
>> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = {
>> VMSTATE_UINT32(slr, PL061State),
>> VMSTATE_UINT32(den, PL061State),
>> VMSTATE_UINT32(cr, PL061State),
>> - VMSTATE_UINT32(float_high, PL061State),
>> VMSTATE_UINT32_V(amsel, PL061State, 2),
>> VMSTATE_END_OF_LIST()
>
> This would be a migration compatibility break, so at a minimum
> you need to bump the vmstate struct versions.
Is it worth the effort to remove this field if it causes
compatibility break? Maybe keep it around, it doesn't hurt?
At the very least, we may rename it to "unused_float_high",
or something, to indicate it is a known-unused?
Thanks,
/mjt
next prev parent reply other threads:[~2016-02-02 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 17:20 [Qemu-devel] [PATCH 1/2] ARM: PL061: Clear PL061 device state after reset Wei Huang
2016-02-01 17:20 ` [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state Wei Huang
2016-02-01 18:01 ` Peter Maydell
2016-02-02 7:03 ` Michael Tokarev [this message]
2016-02-02 15:16 ` Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B054A8.6020602@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).